Skip to content

SearchBox styling issue #3030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Swarnendu0123 opened this issue Feb 17, 2024 · 7 comments · Fixed by #3037
Closed

SearchBox styling issue #3030

Swarnendu0123 opened this issue Feb 17, 2024 · 7 comments · Fixed by #3037

Comments

@Swarnendu0123
Copy link
Contributor

Swarnendu0123 commented Feb 17, 2024

Actual Behavior

Screenshot (80)

Expected Behavior

Screenshot (79)

Steps to reproduce

Steps:

  1. Go to p5.je-web-editor
  2. Press Ctrl+F
  3. A search box will pop up, tap on the arrow on the left
@lindapaiste
Copy link
Collaborator

I think the expected behavior is that the two boxes fit on the same line. We messed this up when adding some changes to support the responsive design. I can look back in the git history and get a snapshot of the earlier version. Pretty sure there is another open issue about this already.

@Swarnendu0123
Copy link
Contributor Author

Swarnendu0123 commented Feb 17, 2024

Hmm, I thought the arrow on click pointing towards the bottom, so the replacement input will also appear to the bottom side.

Pretty sure there is another open issue about this already.

Maybe we can merge them into a single issue.

@VivekJaiswal18
Copy link

Can I work on this issue?

@lindapaiste
Copy link
Collaborator

This is what it previously looked like. The top line stays the same and additional content shows up below.
image
image

Also...omg I thought we fixed this but this is the production site 😱
image

@lindapaiste
Copy link
Collaborator

I have a CSS that fixes it. Whoever gets to it first can put this in a PR. It falls apart below around 350px but that's really small so I think we call this good enough for now and revisit the small-screen issues later.

In .CodeMirror-dialog
change lines:

margin-left: #{math.div(-552 * 0.5, $base-font-size)}rem;
z-index: 10;

Then replace these two blocks:

.CodeMirror-find-controls {
  width: 100%;
  display: flex;
  align-items: center;
  justify-content: space-between;
  height: #{math.div(35, $base-font-size)}rem;
}
.CodeMirror-search-controls {
  width: 60%;
  display: flex;
  flex-wrap: wrap-reverse;
  justify-content: flex-start;
  align-items: flex-end;
}

@PiyushThapaa
Copy link
Contributor

margin-left: #{math.div(-552 * 0.5, $base-font-size)}rem;
@lindapaiste This code is giving a sass error
Screenshot 2024-02-19 171921

@Parikshit2001
Copy link
Contributor

@lindapaiste the code that you provided is working for me
Screenshot 2024-02-20 at 2 24 08 AM
I raised the PR also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants