-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Promisify all mongoose queries using async/await #521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'm on it. |
@dhruvdutt still on it? |
Yeah. I've already started with it. Will be pushing by this week. |
is anyone assigned to this issue? |
@dhruvdutt started working on it but i don't know how far they got. feel free to start on this! |
it might be helpful to work on this in pieces, like promisify one controller at a time or something. |
Ah! I'm sorry, couldn't get back to this. I would be happy to review a PR. |
Working! |
this is a big issue, so i recommend making small PR's! |
@catarak As the task is huge, I too would like to contribute to this. |
Are we prefer the promise |
i definitely prefer async / await! i'll update the issue title. |
We have to change the error handling mechanics with async/await , I have some links , I will post them here |
There's an in-depth conversation about some of the struggles of using async-await with Express: #973 TL;DR It makes sense to include an async middleware like |
@raclim Can I work on this issue? |
@yugalkaushik feel free to give it a go! I'd echo an earlier comment on breaking this down into smaller PRs! |
Nature of issue?
Feature enhancement details:
Right now, all of the mongoose queries use callbacks instead of the new ES6 promise syntax. This should be updated as nested callbacks are difficult to read.
The text was updated successfully, but these errors were encountered: