Use calculated text height instead of OS ascent for better vertical centering (fixes #739)

Author: benfry

core/src/processing/awt/PGraphicsJava2D.java

@@ -1873,10 +1873,16 @@ public float textAscent() {
       defaultFontOrDeath("textAscent");
     }
 
+    // This value is dreadfully inaccurate and inconsistent, and especially
+    // so for the default font. Switching to use our built-in calculation since
+    // our most common use case is likely textAlign(CENTER, CENTER) with the
+    // default font, and it needs to work well there. [fry 230716]
+    /*
     Font font = (Font) textFont.getNative();
     if (font != null) {
       return g2.getFontMetrics(font).getAscent();
     }
+    */
     return super.textAscent();
   }
 
@@ -1886,10 +1892,12 @@ public float textDescent() {
     if (textFont == null) {
       defaultFontOrDeath("textDescent");
     }
+    /*
     Font font = (Font) textFont.getNative();
     if (font != null) {
       return g2.getFontMetrics(font).getDescent();
     }
+    */
     return super.textDescent();
   }
 

todo.txt

@@ -1,6 +1,8 @@
 1293 (4.2.1)
 X `NullPointerException` when background exceeds color range when writing PDF
 X   https://github.com/processing/processing4/issues/740
+X Use calculated text height instead of OS ascent for better vertical centering
+X   https://github.com/processing/processing4/issues/739
 
 sampottinger
 X Syntax error highlighting placement / width incorrect