Skip to content

Commit 1230188

Browse files
committed
update ray version in default template and code references
Signed-off-by: Kevin <[email protected]>
1 parent 9c8c9fa commit 1230188

File tree

16 files changed

+27
-27
lines changed

16 files changed

+27
-27
lines changed

custom-nb-image/Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
FROM quay.io/opendatahub/notebooks:jupyter-minimal-ubi8-python-3.8-4c8f26e
15+
FROM quay.io/opendatahub/notebooks:jupyter-minimal-ubi9-python-3.9-2023a_20230302
1616
# Install: torch (v1.12), ray (v2.1.0) and others
1717

1818
COPY requirements.txt requirements.txt

demo-notebooks/additional-demos/hf_interactive.ipynb

+1-1
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@
9696
" min_memory=16, \n",
9797
" max_memory=16, \n",
9898
" num_gpus=4,\n",
99-
" image=\"quay.io/project-codeflare/ray:2.5.0-py38-cu116\",\n",
99+
" image=\"quay.io/project-codeflare/ray:latest-py39-cu118\",\n",
100100
" instascale=True, machine_types=[\"m5.xlarge\", \"p3.8xlarge\"]))"
101101
]
102102
},

demo-notebooks/guided-demos/0_basic_ray.ipynb

+1-1
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@
6666
" min_memory=4,\n",
6767
" max_memory=4,\n",
6868
" num_gpus=0,\n",
69-
" image=\"quay.io/project-codeflare/ray:2.5.0-py38-cu116\", #current default\n",
69+
" image=\"quay.io/project-codeflare/ray:latest-py39-cu118\", #current default\n",
7070
" instascale=False\n",
7171
"))"
7272
]

demo-notebooks/guided-demos/notebook-ex-outputs/0_basic_ray.ipynb

+1-1
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@
7474
" min_memory=4,\n",
7575
" max_memory=4,\n",
7676
" num_gpus=0,\n",
77-
" image=\"quay.io/project-codeflare/ray:2.5.0-py38-cu116\", #current default\n",
77+
" image=\"quay.io/project-codeflare/ray:latest-py39-cu118\", #current default\n",
7878
" instascale=False\n",
7979
"))"
8080
]

demo-notebooks/guided-demos/notebook-ex-outputs/gptfttest.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ spec:
8181
value: /home/ray/workspace/tls/server.key
8282
- name: RAY_TLS_CA_CERT
8383
value: /home/ray/workspace/tls/ca.crt
84-
image: quay.io/project-codeflare/ray:2.5.0-py38-cu116
84+
image: quay.io/project-codeflare/ray:latest-py39-cu118
8585
imagePullPolicy: Always
8686
lifecycle:
8787
preStop:
@@ -147,7 +147,7 @@ spec:
147147
value: /home/ray/workspace/tls/server.key
148148
- name: RAY_TLS_CA_CERT
149149
value: /home/ray/workspace/tls/ca.crt
150-
image: quay.io/project-codeflare/ray:2.5.0-py38-cu116
150+
image: quay.io/project-codeflare/ray:latest-py39-cu118
151151
lifecycle:
152152
preStop:
153153
exec:

demo-notebooks/guided-demos/notebook-ex-outputs/instascaletest.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ spec:
8181
value: /home/ray/workspace/tls/server.key
8282
- name: RAY_TLS_CA_CERT
8383
value: /home/ray/workspace/tls/ca.crt
84-
image: quay.io/project-codeflare/ray:2.5.0-py38-cu116
84+
image: quay.io/project-codeflare/ray:latest-py39-cu118
8585
imagePullPolicy: Always
8686
lifecycle:
8787
preStop:
@@ -147,7 +147,7 @@ spec:
147147
value: /home/ray/workspace/tls/server.key
148148
- name: RAY_TLS_CA_CERT
149149
value: /home/ray/workspace/tls/ca.crt
150-
image: quay.io/project-codeflare/ray:2.5.0-py38-cu116
150+
image: quay.io/project-codeflare/ray:latest-py39-cu118
151151
lifecycle:
152152
preStop:
153153
exec:

demo-notebooks/guided-demos/notebook-ex-outputs/interactivetest.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ spec:
8181
value: /home/ray/workspace/tls/server.key
8282
- name: RAY_TLS_CA_CERT
8383
value: /home/ray/workspace/tls/ca.crt
84-
image: quay.io/project-codeflare/ray:2.5.0-py38-cu116
84+
image: quay.io/project-codeflare/ray:latest-py39-cu118
8585
imagePullPolicy: Always
8686
lifecycle:
8787
preStop:
@@ -147,7 +147,7 @@ spec:
147147
value: /home/ray/workspace/tls/server.key
148148
- name: RAY_TLS_CA_CERT
149149
value: /home/ray/workspace/tls/ca.crt
150-
image: quay.io/project-codeflare/ray:2.5.0-py38-cu116
150+
image: quay.io/project-codeflare/ray:latest-py39-cu118
151151
lifecycle:
152152
preStop:
153153
exec:

demo-notebooks/guided-demos/notebook-ex-outputs/jobtest.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ spec:
7070
value: /home/ray/workspace/tls/server.key
7171
- name: RAY_TLS_CA_CERT
7272
value: /home/ray/workspace/tls/ca.crt
73-
image: quay.io/project-codeflare/ray:2.5.0-py38-cu116
73+
image: quay.io/project-codeflare/ray:latest-py39-cu118
7474
imagePullPolicy: Always
7575
lifecycle:
7676
preStop:
@@ -127,7 +127,7 @@ spec:
127127
value: /home/ray/workspace/tls/server.key
128128
- name: RAY_TLS_CA_CERT
129129
value: /home/ray/workspace/tls/ca.crt
130-
image: quay.io/project-codeflare/ray:2.5.0-py38-cu116
130+
image: quay.io/project-codeflare/ray:latest-py39-cu118
131131
lifecycle:
132132
preStop:
133133
exec:

demo-notebooks/guided-demos/notebook-ex-outputs/raytest.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ spec:
7070
value: /home/ray/workspace/tls/server.key
7171
- name: RAY_TLS_CA_CERT
7272
value: /home/ray/workspace/tls/ca.crt
73-
image: quay.io/project-codeflare/ray:2.5.0-py38-cu116
73+
image: quay.io/project-codeflare/ray:latest-py39-cu118
7474
imagePullPolicy: Always
7575
lifecycle:
7676
preStop:
@@ -127,7 +127,7 @@ spec:
127127
value: /home/ray/workspace/tls/server.key
128128
- name: RAY_TLS_CA_CERT
129129
value: /home/ray/workspace/tls/ca.crt
130-
image: quay.io/project-codeflare/ray:2.5.0-py38-cu116
130+
image: quay.io/project-codeflare/ray:latest-py39-cu118
131131
lifecycle:
132132
preStop:
133133
exec:

demo-notebooks/guided-demos/preview_nbs/0_basic_ray.ipynb

+1-1
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@
6666
" min_memory=4,\n",
6767
" max_memory=4,\n",
6868
" num_gpus=0,\n",
69-
" image=\"quay.io/project-codeflare/ray:2.5.0-py38-cu116\", #current default\n",
69+
" image=\"quay.io/project-codeflare/ray:latest-py39-cu118\", #current default\n",
7070
" instascale=False\n",
7171
"))"
7272
]

pyproject.toml

+2-2
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,10 @@ homepage = "https://github.com/project-codeflare/codeflare-sdk"
2020
keywords = ['codeflare', 'python', 'sdk', 'client', 'batch', 'scale']
2121

2222
[tool.poetry.dependencies]
23-
python = "^3.9"
23+
python = "^3.8"
2424
openshift-client = "1.0.18"
2525
rich = "^12.5"
26-
ray = {version = "2.7.0", extras = ["default"]}
26+
ray = {version = "~=2.7", extras = ["default"]}
2727
kubernetes = ">= 25.3.0, < 27"
2828
codeflare-torchx = "0.6.0.dev1"
2929
cryptography = "40.0.2"

src/codeflare_sdk/cluster/config.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ class ClusterConfiguration:
4747
template: str = f"{dir}/templates/base-template.yaml"
4848
instascale: bool = False
4949
envs: dict = field(default_factory=dict)
50-
image: str = "quay.io/project-codeflare/ray:2.5.0-py38-cu116"
50+
image: str = "quay.io/project-codeflare/ray:latest-py39-cu118"
5151
local_interactive: bool = False
5252
image_pull_secrets: list = field(default_factory=list)
5353
dispatch_priority: str = None

tests/test-case-bad.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ spec:
7373
valueFrom:
7474
fieldRef:
7575
fieldPath: status.podIP
76-
image: quay.io/project-codeflare/ray:2.5.0-py38-cu116
76+
image: quay.io/project-codeflare/ray:latest-py39-cu118
7777
imagePullPolicy: Always
7878
lifecycle:
7979
preStop:
@@ -130,7 +130,7 @@ spec:
130130
valueFrom:
131131
fieldRef:
132132
fieldPath: status.podIP
133-
image: quay.io/project-codeflare/ray:2.5.0-py38-cu116
133+
image: quay.io/project-codeflare/ray:latest-py39-cu118
134134
lifecycle:
135135
preStop:
136136
exec:

tests/test-case-prio.yaml

+3-3
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ spec:
8181
value: /home/ray/workspace/tls/server.key
8282
- name: RAY_TLS_CA_CERT
8383
value: /home/ray/workspace/tls/ca.crt
84-
image: quay.io/project-codeflare/ray:2.5.0-py38-cu116
84+
image: quay.io/project-codeflare/ray:latest-py39-cu118
8585
imagePullPolicy: Always
8686
lifecycle:
8787
preStop:
@@ -110,7 +110,7 @@ spec:
110110
imagePullSecrets:
111111
- name: unit-test-pull-secret
112112
priorityClassName: default
113-
rayVersion: 2.5.0
113+
rayVersion: 2.7.0
114114
workerGroupSpecs:
115115
- groupName: small-group-prio-test-cluster
116116
maxReplicas: 2
@@ -149,7 +149,7 @@ spec:
149149
value: /home/ray/workspace/tls/server.key
150150
- name: RAY_TLS_CA_CERT
151151
value: /home/ray/workspace/tls/ca.crt
152-
image: quay.io/project-codeflare/ray:2.5.0-py38-cu116
152+
image: quay.io/project-codeflare/ray:latest-py39-cu118
153153
lifecycle:
154154
preStop:
155155
exec:

tests/test-case.yaml

+3-3
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ spec:
8080
value: /home/ray/workspace/tls/server.key
8181
- name: RAY_TLS_CA_CERT
8282
value: /home/ray/workspace/tls/ca.crt
83-
image: quay.io/project-codeflare/ray:2.5.0-py38-cu116
83+
image: quay.io/project-codeflare/ray:latest-py39-cu118
8484
imagePullPolicy: Always
8585
lifecycle:
8686
preStop:
@@ -108,7 +108,7 @@ spec:
108108
nvidia.com/gpu: 0
109109
imagePullSecrets:
110110
- name: unit-test-pull-secret
111-
rayVersion: 2.5.0
111+
rayVersion: 2.7.0
112112
workerGroupSpecs:
113113
- groupName: small-group-unit-test-cluster
114114
maxReplicas: 2
@@ -147,7 +147,7 @@ spec:
147147
value: /home/ray/workspace/tls/server.key
148148
- name: RAY_TLS_CA_CERT
149149
value: /home/ray/workspace/tls/ca.crt
150-
image: quay.io/project-codeflare/ray:2.5.0-py38-cu116
150+
image: quay.io/project-codeflare/ray:latest-py39-cu118
151151
lifecycle:
152152
preStop:
153153
exec:

tests/unit_test.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,7 @@ def test_config_creation():
231231
assert config.min_cpus == 3 and config.max_cpus == 4
232232
assert config.min_memory == 5 and config.max_memory == 6
233233
assert config.num_gpus == 7
234-
assert config.image == "quay.io/project-codeflare/ray:2.5.0-py38-cu116"
234+
assert config.image == "quay.io/project-codeflare/ray:latest-py39-cu118"
235235
assert config.template == f"{parent}/src/codeflare_sdk/templates/base-template.yaml"
236236
assert config.instascale
237237
assert config.machine_types == ["cpu.small", "gpu.large"]

0 commit comments

Comments
 (0)