Skip to content

Commit 1aefc04

Browse files
change 'priority' to 'dispatch priority'
1 parent 8aee088 commit 1aefc04

File tree

5 files changed

+15
-7
lines changed

5 files changed

+15
-7
lines changed

src/codeflare_sdk/cluster/cluster.py

+8
Original file line numberDiff line numberDiff line change
@@ -89,12 +89,16 @@ def create_app_wrapper(self):
8989
instascale = self.config.instascale
9090
instance_types = self.config.machine_types
9191
env = self.config.envs
92+
<<<<<<< HEAD
9293
<<<<<<< HEAD
9394
local_interactive = self.config.local_interactive
9495
image_pull_secrets = self.config.image_pull_secrets
9596
=======
9697
priority = self.config.priority
9798
>>>>>>> 7e7a311 ( add priorities and schedulingSpec to SDK)
99+
=======
100+
dispatch_priority = self.config.dispatch_priority
101+
>>>>>>> b1d1d16 (change 'priority' to 'dispatch priority')
98102
return generate_appwrapper(
99103
name=name,
100104
namespace=namespace,
@@ -109,12 +113,16 @@ def create_app_wrapper(self):
109113
instascale=instascale,
110114
instance_types=instance_types,
111115
env=env,
116+
<<<<<<< HEAD
112117
<<<<<<< HEAD
113118
local_interactive=local_interactive,
114119
image_pull_secrets=image_pull_secrets,
115120
=======
116121
priority=priority,
117122
>>>>>>> 7e7a311 ( add priorities and schedulingSpec to SDK)
123+
=======
124+
dispatch_priority=dispatch_priority,
125+
>>>>>>> b1d1d16 (change 'priority' to 'dispatch priority')
118126
)
119127

120128
# creates a new cluster with the provided or default spec

src/codeflare_sdk/cluster/config.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,4 +48,4 @@ class ClusterConfiguration:
4848
image: str = "quay.io/project-codeflare/ray:2.5.0-py38-cu116"
4949
local_interactive: bool = False
5050
image_pull_secrets: list = field(default_factory=list)
51-
51+
dispatch_priority: str = "default"

src/codeflare_sdk/utils/generate_yaml.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -336,7 +336,7 @@ def generate_appwrapper(
336336
env,
337337
local_interactive: bool,
338338
image_pull_secrets: list,
339-
priority: str,
339+
dispatch_priority: str,
340340
):
341341
user_yaml = read_template(template)
342342
appwrapper_name, cluster_name = gen_names(name)
@@ -345,7 +345,7 @@ def generate_appwrapper(
345345
route_item = resources["resources"].get("GenericItems")[1]
346346
update_names(user_yaml, item, appwrapper_name, cluster_name, namespace)
347347
update_labels(user_yaml, instascale, instance_types)
348-
update_priority(user_yaml, item, priority)
348+
update_priority(user_yaml, item, dispatch_priority)
349349
update_scheduling_spec(user_yaml, workers)
350350
update_custompodresources(
351351
item, min_cpu, max_cpu, min_memory, max_memory, gpu, workers

tests/test-case.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ metadata:
66
name: unit-test-cluster
77
namespace: ns
88
spec:
9-
priority: 1
9+
priority: 5
1010
resources:
1111
GenericItems:
1212
- custompodresources:
@@ -176,7 +176,7 @@ spec:
176176
do echo waiting for myservice; sleep 2; done
177177
image: busybox:1.28
178178
name: init-myservice
179-
priorityClassName: low-priority
179+
priorityClassName: default-priority
180180
replicas: 1
181181
- generictemplate:
182182
apiVersion: route.openshift.io/v1

tests/unit_test.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ def test_config_creation():
183183
instascale=True,
184184
machine_types=["cpu.small", "gpu.large"],
185185
image_pull_secrets=["unit-test-pull-secret"],
186-
priority="low",
186+
dispatch_priority="default",
187187
)
188188

189189
assert config.name == "unit-test-cluster" and config.namespace == "ns"
@@ -196,7 +196,7 @@ def test_config_creation():
196196
assert config.instascale
197197
assert config.machine_types == ["cpu.small", "gpu.large"]
198198
assert config.image_pull_secrets == ["unit-test-pull-secret"]
199-
assert config.priority == "low"
199+
assert config.dispatch_priority == "default"
200200
return config
201201

202202

0 commit comments

Comments
 (0)