Skip to content

Commit 3936598

Browse files
committed
GitHub Release Action Fixes
This fixes a few issues that were discovered in the CodeFlare 0.0.5 release 1. Tag image as stable, not latest. We have switched over to using podman as well 2. Update github release step to include release notes 3. Move github tag + release step to end Signed-off-by: Anish Asthana <[email protected]>
1 parent baec858 commit 3936598

File tree

1 file changed

+16
-14
lines changed

1 file changed

+16
-14
lines changed

.github/workflows/release.yaml

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@ on:
66
release-version:
77
type: string
88
required: true
9-
description: 'Version number (for example: 0.1.0)'
10-
is-latest:
11-
description: 'Select if the built image should be tagged as latest'
9+
description: 'Version number (This should not include `v`, for example: 0.1.0)'
10+
is-stable:
11+
description: 'Select if the built image should be tagged as stable'
1212
required: true
1313
type: boolean
1414
quay-organization:
@@ -57,25 +57,27 @@ jobs:
5757
uses: stefanzweifel/git-auto-commit-action@v4
5858
with:
5959
file_pattern: 'docs'
60-
commit_message: "Changes in docs for release: v${{ github.event.inputs.release-version }}"
61-
- name: Create Github release
62-
uses: ncipollo/release-action@v1
63-
with:
64-
tag: "v${{ github.event.inputs.release-version }}"
60+
commit_message: "Changes in docs for release: ${{ github.event.inputs.release-version }}"
6561

6662
- name: Image Build
6763
run: |
6864
cd custom-nb-image
69-
docker build --build-arg SDK_VERSION="${{ github.event.inputs.release-version }}" -t quay.io/${{ github.event.inputs.quay-organization }}/notebook:v${{ github.event.inputs.release-version }} .
70-
docker tag quay.io/${{ github.event.inputs.quay-organization }}/notebook:v${{ github.event.inputs.release-version }} quay.io/${{ github.event.inputs.quay-organization }}/notebook:latest
65+
podman build --build-arg SDK_VERSION="${{ github.event.inputs.release-version }}" -t quay.io/${{ github.event.inputs.quay-organization }}/notebook:v${{ github.event.inputs.release-version }} .
66+
7167
- name: Login to Quay.io
7268
uses: docker/login-action@v2
7369
with:
7470
registry: quay.io
7571
username: ${{ secrets.QUAY_ID }}
7672
password: ${{ secrets.QUAY_TOKEN }}
73+
7774
- name: Image Push
78-
run: docker push quay.io/${{ github.event.inputs.quay-organization }}/notebook:v${{ github.event.inputs.release-version }}
79-
- name: Image Push Latest
80-
if: ${{ inputs.is-latest }}
81-
run: docker push quay.io/${{ github.event.inputs.quay-organization }}/notebook:latest
75+
run: |
76+
podman push quay.io/${{ github.event.inputs.quay-organization }}/notebook:v${{ github.event.inputs.release-version }}
77+
podman push quay.io/${{ github.event.inputs.quay-organization }}/notebook:v${{ github.event.inputs.release-version }} quay.io/${{ github.event.inputs.quay-organization }}/notebook:stable
78+
79+
- name: Create Github release
80+
uses: ncipollo/release-action@v1
81+
with:
82+
tag: "${{ github.event.inputs.release-version }}"
83+
generateReleaseNotes: true

0 commit comments

Comments
 (0)