Skip to content

Release workflow should open a PR with changes instead of direct push #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sutaakar opened this issue Aug 8, 2023 · 0 comments · Fixed by #315
Closed

Release workflow should open a PR with changes instead of direct push #290

sutaakar opened this issue Aug 8, 2023 · 0 comments · Fixed by #315
Assignees
Labels
testing Items related to testing

Comments

@sutaakar
Copy link
Contributor

sutaakar commented Aug 8, 2023

Right now the release workflow pushes the release changes directly into the branch.
This approach doesn't work out of the box due to the branch protection in repository. As a result branch protection has to be disabled during release.

Release workflow should open a PR instead of pushing changes directly and wait until the PR is merged by OpenShift CI.

Also release workflow should release to Pypi repository as a last step, to make sure that the release flow will pass. The reason is that Pypi release cannot be deleted/reverted.

Also make sure that all created release artefacts (i.e. created release on GitHub and such) are removed in case release workflow fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Items related to testing
Projects
2 participants