Skip to content

Wrong RayCluster labels #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
roytman opened this issue Oct 12, 2023 · 0 comments · Fixed by #384
Closed

Wrong RayCluster labels #383

roytman opened this issue Oct 12, 2023 · 0 comments · Fixed by #384
Assignees
@ChristianZaccaria

Comments

@roytman
Copy link
Contributor

roytman commented Oct 12, 2023

Describe the Bug

Recently MCAD API version was changed to workload.codeflare.dev, however CodeFlare SDK sets labels with the old api version to RayClusters.

Codeflare Stack Component Versions

Please specify the component versions in which you have encountered this bug.

Codeflare SDK:

Steps to Reproduce the Bug

Create a RayCluster and check its labels.

Affected Releases

List any release versions, git commit hashes, or git tags, etc. that you know show the bug. If it is the latest HEAD on main, just put that.

Additional Context

see

codeflare-sdk/src/codeflare_sdk/templates/base-template.yaml

Line 44 in 06a3a59

appwrapper.mcad.ibm.com: "aw-kuberay"

and

codeflare-sdk/src/codeflare_sdk/utils/generate_yaml.py

Line 71 in 06a3a59

lower_meta["labels"]["appwrapper.mcad.ibm.com"] = appwrapper_name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChristianZaccaria ChristianZaccaria

Labels
None yet
Projects
Project CodeFlare Sprint Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update RayCluster labels to workload.codeflare.dev/appwrappers ChristianZaccaria/codeflare-sdk
2 participants
@roytman @ChristianZaccaria