Skip to content

Commit 0e8771a

Browse files
committed
docs: note blob streaming idle-timeout behaviour
Clarify on the ReadTimeout/WriteTimeout config fields that blob transfers extend the deadline per read/write, so it behaves as an idle timeout for them rather than a cap on total transfer time. Signed-off-by: Paul Kennedy <9027062+datadot@users.noreply.github.com>
1 parent caa692f commit 0e8771a

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

pkg/api/config/config.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -386,11 +386,13 @@ type HTTPConfig struct {
386386
AllowOrigin string // comma separated
387387
// ReadTimeout controls maximum duration for reading the entire request (including body).
388388
// When unset (nil), server-level defaults may apply. When explicitly set to <= 0,
389-
// the HTTP server treats it as no timeout.
389+
// the HTTP server treats it as no timeout. Blob uploads extend this deadline per read,
390+
// so it acts as an idle timeout for them rather than a cap on total upload time.
390391
ReadTimeout *time.Duration `mapstructure:"readTimeout,omitempty"`
391392
// WriteTimeout controls maximum duration before timing out response writes.
392393
// When unset (nil), server-level defaults may apply. When explicitly set to <= 0,
393-
// the HTTP server treats it as no timeout.
394+
// the HTTP server treats it as no timeout. Blob downloads extend this deadline per write,
395+
// so it acts as an idle timeout for them rather than a cap on total download time.
394396
WriteTimeout *time.Duration `mapstructure:"writeTimeout,omitempty"`
395397
TLS *TLSConfig
396398
Auth *AuthConfig

0 commit comments

Comments
 (0)