Skip to content

Commit 513f2a0

Browse files
fix(s3): fix check in dedupe logic (#2700)
cache.HasBlob() looks in both buckets: duplicates and original blobs Because we want to check if the blob is in original bucket let's use cache.GetBlob() because it's looking only in original bucket. Signed-off-by: Eusebiu Petu <petu.eusebiu@gmail.com>
1 parent e6624a2 commit 513f2a0

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

pkg/storage/imagestore/imagestore.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1930,7 +1930,7 @@ func (is *ImageStore) dedupeBlobs(ctx context.Context, digest godigest.Digest, d
19301930
}
19311931

19321932
// cache original blob
1933-
if ok := is.cache.HasBlob(digest, originalBlob); !ok {
1933+
if _, err := is.cache.GetBlob(digest); err != nil {
19341934
if err := is.cache.PutBlob(digest, originalBlob); err != nil {
19351935
return err
19361936
}

0 commit comments

Comments
 (0)