fix(test/blackbox): address Copilot review feedback in push/pull helpers

Use curl --fail for manifest deletes so HTTP errors fail the test. Remove
the duplicate regctl --format flag in helper_push_manifest_with_regclient.
Harden helper_authn_ml_artifacts with run and status checks, using a
binary-safe shell redirect for the ONNX artifact round-trip.

Signed-off-by: Andrei Aaron <andreifdaaron@gmail.com>

Author: andaaron

test/blackbox/helpers_pushpull.bash

@@ -224,7 +224,7 @@ function helper_delete_manifest() {
     local zot_port
     zot_port=$(get_zot_port)
 
-    run curl -X DELETE "http://127.0.0.1:${zot_port}/v2/${image_name}/manifests/${tag}"
+    run curl --fail -X DELETE "http://127.0.0.1:${zot_port}/v2/${image_name}/manifests/${tag}"
     [ "${status}" -eq 0 ]
 }
 
@@ -438,8 +438,7 @@ function helper_push_manifest_with_regclient() {
 
     run regctl manifest put "localhost:${zot_port}/test-regclient:1.0.0" \
         --format oci \
-        --content-type application/vnd.oci.image.manifest.v1+json \
-        --format oci <<JSON
+        --content-type application/vnd.oci.image.manifest.v1+json <<JSON
 ${manifest}
 JSON
     [ "${status}" -eq 0 ]

test/blackbox/helpers_pushpull_authn.bash

@@ -206,31 +206,46 @@ function helper_authn_list_oci_artifact_references_with_regclient() {
 function helper_authn_ml_artifacts() {
     local user=${1:-${AUTH_USER}}
     local pass=${2:-${AUTH_PASS}}
+    local zot_port sha256_in sha256_out
 
     helper_authn_regctl_login "${user}" "${pass}"
+    zot_port=$(get_zot_port)
 
-    curl -v -L0 \
+    run curl --fail -L -0 \
         https://github.com/tarilabs/demo20231212/raw/main/v1.nb20231206162408/mnist.onnx \
         -o "${BATS_FILE_TMPDIR}/mnist.onnx"
-    sha256_in=$(sha256sum "${BATS_FILE_TMPDIR}/mnist.onnx" | awk '{print $1}')
+    [ "${status}" -eq 0 ]
+
+    run sha256sum "${BATS_FILE_TMPDIR}/mnist.onnx"
+    [ "${status}" -eq 0 ]
+    sha256_in=$(echo "${output}" | awk '{print $1}')
+    [ -n "${sha256_in}" ]
 
-    regctl artifact put \
+    run regctl artifact put \
         --annotation description="used for demo purposes" \
         --annotation model_format_name="onnx" \
         --annotation model_format_version="1" \
         --artifact-type "application/vnd.model.type" \
-        "localhost:$(get_zot_port)/models/my-model-from-gh:v1" \
+        "localhost:${zot_port}/models/my-model-from-gh:v1" \
         -f "${BATS_FILE_TMPDIR}/mnist.onnx"
+    [ "${status}" -eq 0 ]
 
-    regctl artifact list "localhost:$(get_zot_port)/models/my-model-from-gh:v1" \
+    run regctl artifact list "localhost:${zot_port}/models/my-model-from-gh:v1" \
         --format '{{jsonPretty .}}'
-    regctl artifact list --filter-artifact-type "application/vnd.model.type" \
-        "localhost:$(get_zot_port)/models/my-model-from-gh:v1" \
+    [ "${status}" -eq 0 ]
+
+    run regctl artifact list --filter-artifact-type "application/vnd.model.type" \
+        "localhost:${zot_port}/models/my-model-from-gh:v1" \
         --format '{{jsonPretty .}}'
+    [ "${status}" -eq 0 ]
 
-    regctl artifact get "localhost:$(get_zot_port)/models/my-model-from-gh:v1" \
-        >"${BATS_FILE_TMPDIR}/mnist.onnx.check"
-    sha256_out=$(sha256sum "${BATS_FILE_TMPDIR}/mnist.onnx.check" | awk '{print $1}')
+    run bash -c "regctl artifact get 'localhost:${zot_port}/models/my-model-from-gh:v1' >'${BATS_FILE_TMPDIR}/mnist.onnx.check'"
+    [ "${status}" -eq 0 ]
+
+    run sha256sum "${BATS_FILE_TMPDIR}/mnist.onnx.check"
+    [ "${status}" -eq 0 ]
+    sha256_out=$(echo "${output}" | awk '{print $1}')
+    [ -n "${sha256_out}" ]
     [ "${sha256_in}" = "${sha256_out}" ]
 }