Skip to content

Commit afc7822

Browse files
revmischaclaude
authored andcommitted
Fix signing for Frameworks, rename job, add trailing newline
- Sign dylibs in Contents/Frameworks (SDL2, Poco) - Rename misleading build-deb job to build-pkg - Add missing newline at end of component plist Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent 9e73972 commit afc7822

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

.github/workflows/release-macos.yaml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ on:
2020
required: true
2121

2222
jobs:
23-
build-deb:
23+
build-pkg:
2424
name: ProductBuild Installer, macOS x86_64+arm64
2525
runs-on: macos-latest
2626

@@ -158,7 +158,13 @@ jobs:
158158
IDENTITY="Developer ID Application: Mischa Spiegelmock (5926VBQM6Y)"
159159
ENTITLEMENTS="${{ github.workspace }}/frontend-sdl2/src/resources/projectMSDL.entitlements"
160160
161-
# Sign all dylibs first (if PlugIns directory exists)
161+
# Sign frameworks first (SDL2, Poco, etc.)
162+
if [ -d "$APP_PATH/Contents/Frameworks" ]; then
163+
find "$APP_PATH/Contents/Frameworks" \( -name "*.dylib" -o -name "*.framework" \) -exec \
164+
codesign --force --options runtime --sign "$IDENTITY" {} \;
165+
fi
166+
167+
# Sign plugins if present
162168
if [ -d "$APP_PATH/Contents/PlugIns" ]; then
163169
find "$APP_PATH/Contents/PlugIns" -name "*.dylib" -exec \
164170
codesign --force --options runtime --sign "$IDENTITY" {} \;

src/resources/projectMSDL-component.plist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,4 @@
1515
<string>projectM.app</string>
1616
</dict>
1717
</array>
18-
</plist>
18+
</plist>

0 commit comments

Comments
 (0)