Skip to content

Commit ea913dc

Browse files
committed
feat: added tests for ipv6 validation + fixed typo
1 parent 5a7657e commit ea913dc

File tree

2 files changed

+19
-1
lines changed

2 files changed

+19
-1
lines changed

networkpolicy.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import (
1414
func init() {
1515
DefaultOptions.DenyList = append(DefaultOptions.DenyList, DefaultIPv4DenylistRanges...)
1616
DefaultOptions.DenyList = append(DefaultOptions.DenyList, DefaultIPv6Denylist...)
17-
DefaultOptions.DenyList = append(DefaultOptions.DenyList, DefaultIPv4DenylistRanges...)
17+
DefaultOptions.DenyList = append(DefaultOptions.DenyList, DefaultIPv6DenylistRanges...)
1818
DefaultOptions.DenyList = append(DefaultOptions.DenyList, DefaultIPv6Denylist...)
1919
DefaultOptions.AllowSchemeList = append(DefaultOptions.DenyList, DefaultSchemeAllowList...)
2020
}

networkpolicy_test.go

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,24 @@ func TestValidateAddress(t *testing.T) {
2424
require.Equal(t, true, ok, "Unexpected negative result")
2525
}
2626

27+
func Test_ValidateV6Address(t *testing.T) {
28+
np, err := New(DefaultOptions)
29+
if err != nil {
30+
log.Fatal(err)
31+
}
32+
33+
ok := np.ValidateAddress("::1")
34+
require.Equal(t, false, ok, "IPv6 localhost should be denied")
35+
36+
ok = np.ValidateAddress("2404:6800:4002:81c::200e")
37+
require.Equal(t, true, ok, "Non-localhost IPv6 should be allowed")
38+
39+
t.Run("validate", func(t *testing.T) {
40+
ok := np.Validate("::1")
41+
require.Equal(t, false, ok, "IPv6 localhost should be denied")
42+
})
43+
}
44+
2745
func TestMultipleCases(t *testing.T) {
2846
var testCases = []struct {
2947
address string

0 commit comments

Comments
 (0)