chore: satisfy lints

Signed-off-by: Dwi Siswanto <[email protected]>

Author: dwisiswant0

default_client_test.go

@@ -30,7 +30,7 @@ func TestConnectionReuse(t *testing.T) {
 
 	router := httprouter.New()
 	router.GET("/", func(w http.ResponseWriter, r *http.Request, _ httprouter.Params) {
-		fmt.Fprintf(w, "this is a test")
+		_, _ = fmt.Fprintf(w, "this is a test")
 	})
 	ts := httptest.NewServer(router)
 	defer ts.Close()
@@ -55,7 +55,7 @@ func TestConnectionReuse(t *testing.T) {
 				resp, err := client.Do(req)
 				require.Nil(t, err)
 				_, _ = io.Copy(io.Discard, resp.Body)
-				resp.Body.Close()
+				_ = resp.Body.Close()
 			}
 		}()
 	}

do.go

@@ -127,7 +127,7 @@ func (c *Client) Do(req *Request) (*http.Response, error) {
 	// By default, we close the response body and return an error without
 	// returning the response
 	if resp != nil {
-		resp.Body.Close()
+		_ = resp.Body.Close()
 	}
 	c.closeIdleConnections()
 	return nil, fmt.Errorf("%s %s giving up after %d attempts: %w", req.Method, req.URL, retryMax+1, err)
@@ -139,7 +139,7 @@ func (c *Client) drainBody(req *Request, resp *http.Response) {
 	if err != nil {
 		req.Metrics.DrainErrors++
 	}
-	resp.Body.Close()
+	_ = resp.Body.Close()
 }
 
 const closeConnectionsCounter = 100
@@ -248,5 +248,5 @@ func (c *Client) wrapContextWithTrace(req *Request) {
 	}
 	req.TraceInfo = traceInfo
 
-	req.Request = req.Request.WithContext(httptrace.WithClientTrace(req.Request.Context(), trace))
+	req.Request = req.Request.WithContext(httptrace.WithClientTrace(req.Context(), trace))
 }

request.go

@@ -93,7 +93,7 @@ func (r *Request) WithContext(ctx context.Context) *Request {
 // This function is not thread-safe; do not call it at the same time as another
 // call, or at the same time this request is being used with Client.Do.
 func (r *Request) BodyBytes() ([]byte, error) {
-	if r.Request.Body == nil {
+	if r.Body == nil {
 		return nil, nil
 	}
 	buf := new(bytes.Buffer)

request_test.go

@@ -98,7 +98,7 @@ func TestRedirectPOSTWithBody(t *testing.T) {
 	if err != nil {
 		t.Fatalf("client.Do failed: %v", err)
 	}
-	defer resp.Body.Close()
+	defer func() { _ = resp.Body.Close() }()
 
 	if resp.StatusCode != http.StatusOK {
 		body, _ := io.ReadAll(resp.Body)
@@ -135,7 +135,7 @@ func TestRedirectPOSTWithBodyFromRequest(t *testing.T) {
 	if err != nil {
 		t.Fatalf("client.Do failed: %v", err)
 	}
-	defer resp.Body.Close()
+	defer func() { _ = resp.Body.Close() }()
 
 	if resp.StatusCode != http.StatusOK {
 		body, _ := io.ReadAll(resp.Body)
@@ -158,7 +158,7 @@ func setupRedirectServer(t *testing.T, expectedBody string) *httptest.Server {
 		if err != nil {
 			t.Logf("redirect read body err: %v", err)
 		}
-		r.Body.Close()
+		_ = r.Body.Close()
 
 		w.Header().Set("Location", "/target")
 		w.WriteHeader(http.StatusTemporaryRedirect) // 307
@@ -170,24 +170,24 @@ func setupRedirectServer(t *testing.T, expectedBody string) *httptest.Server {
 			w.WriteHeader(http.StatusInternalServerError)
 			return
 		}
-		r.Body.Close()
+		_ = r.Body.Close()
 
 		if len(body) == 0 {
 			w.WriteHeader(http.StatusBadRequest)
-			w.Write([]byte("empty body"))
+			_, _ = w.Write([]byte("empty body"))
 
 			return
 		}
 
 		if string(body) != expectedBody {
 			w.WriteHeader(http.StatusBadRequest)
-			w.Write([]byte("body mismatch"))
+			_, _ = w.Write([]byte("body mismatch"))
 
 			return
 		}
 
 		w.WriteHeader(http.StatusOK)
-		w.Write([]byte("success"))
+		_, _ = w.Write([]byte("success"))
 	})
 
 	return httptest.NewServer(mux)

util.go

@@ -19,7 +19,7 @@ func Discard(req *Request, resp *http.Response, RespReadLimit int64) {
 	if err != nil {
 		req.Metrics.DrainErrors++
 	}
-	resp.Body.Close()
+	_ = resp.Body.Close()
 }
 
 // getLength returns length of a Reader efficiently