Skip to content

Commit 4fbe7c7

Browse files
committed
Unpack postgres arrays for process idle times correctly
Signed-off-by: Tom Hughes <[email protected]>
1 parent d01184f commit 4fbe7c7

File tree

1 file changed

+17
-4
lines changed

1 file changed

+17
-4
lines changed

collector/pg_process_idle.go

+17-4
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import (
1818
"database/sql"
1919

2020
"github.com/go-kit/log"
21+
"github.com/lib/pq"
2122
"github.com/prometheus/client_golang/prometheus"
2223
)
2324

@@ -84,17 +85,29 @@ func (PGProcessIdleCollector) Update(ctx context.Context, instance *instance, ch
8485
var applicationName sql.NullString
8586
var secondsSum sql.NullInt64
8687
var secondsCount sql.NullInt64
87-
var seconds []uint64
88-
var secondsBucket []uint64
88+
var rawSeconds []byte
89+
var rawSecondsBucket []byte
8990

90-
err := row.Scan(&applicationName, &secondsSum, &secondsCount, &seconds, &secondsBucket)
91+
err := row.Scan(&applicationName, &secondsSum, &secondsCount, &rawSeconds, &rawSecondsBucket)
92+
93+
var seconds []float64
94+
err = pq.Array(&seconds).Scan(rawSeconds)
95+
if err != nil {
96+
return err
97+
}
98+
99+
var secondsBucket []int64
100+
err = pq.Array(&secondsBucket).Scan(rawSecondsBucket)
101+
if err != nil {
102+
return err
103+
}
91104

92105
var buckets = make(map[float64]uint64, len(seconds))
93106
for i, second := range seconds {
94107
if i >= len(secondsBucket) {
95108
break
96109
}
97-
buckets[float64(second)] = secondsBucket[i]
110+
buckets[second] = uint64(secondsBucket[i])
98111
}
99112
if err != nil {
100113
return err

0 commit comments

Comments
 (0)