Skip to content

Commit b923e13

Browse files
authored
Merge pull request #89 from Kjarrigan/extend-invalid-signature-message
Extend the invalid signature message
2 parents 011aaf9 + f593eb8 commit b923e13

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

lib/prometheus/client/label_set_validator.rb

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,9 @@ def validate(labels)
3535
valid?(labels)
3636

3737
unless @validated.empty? || match?(labels, @validated.first.last)
38-
raise InvalidLabelSetError, 'labels must have the same signature'
38+
raise InvalidLabelSetError, "labels must have the same signature " \
39+
"(keys given: #{labels.keys.sort} vs." \
40+
" keys expected: #{@validated.first.last.keys.sort}"
3941
end
4042

4143
@validated[labels.hash] = labels

spec/prometheus/client/label_set_validator_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@
6363

6464
expect do
6565
validator.validate(method: 'get', exception: 'NoMethodError')
66-
end.to raise_exception(invalid)
66+
end.to raise_exception(invalid, /keys given: \[:exception, :method\] vs. keys expected: \[:code, :method\]/)
6767
end
6868
end
6969
end

0 commit comments

Comments
 (0)