fix: Consistently handle scalar map keys#2186
Merged
Merged
Conversation
| * @returns {boolean} Boolean value | ||
| */ | ||
| util.boolFromKey = function boolFromKey(key) { | ||
| return key === "true" || key === "1"; |
Contributor
There was a problem hiding this comment.
or maybe even true if Number.isInteger(key) and it's not zero?
Member
Author
There was a problem hiding this comment.
Good point. Here, keys are always strings, so Number.isInteger("2") would be false unless we convert first. Since this currently lines up with util.key2Re = /^true|false|0|1$/;, I’d lean toward keeping it analogous for now.
alexander-fenster
approved these changes
Apr 28, 2026
Member
Author
|
Note: this will once more need a follow-up protobufjs-cli peer dependency bump after the next protobufjs release due to the new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes encoding and object conversion of scalar map keys that are stored internally as strings, enabling round-tripping of boolean and 64-bit map keys.
Also fixes the 64-bit map key check to accept the documented internal format.
Fixes #1203
Fixes #1652
Fixes #2087
Supersedes #1653
Supersedes #1669