Consume result from various SampleRecorder methods.

PiperOrigin-RevId: 897953609

Author: ckennelly

src/google/protobuf/arenaz_sampler_test.cc

@@ -50,15 +50,16 @@ class ThreadSafeArenaStatsHandlePeer {
 
 std::vector<size_t> GetBytesAllocated(ThreadSafeArenazSampler* s) {
   std::vector<size_t> res;
-  s->Iterate([&](const ThreadSafeArenaStats& info) {
+  EXPECT_EQ(s->Iterate([&](const ThreadSafeArenaStats& info) {
     for (const auto& block_stats : info.block_histogram) {
       size_t bytes_allocated =
           block_stats.bytes_allocated.load(std::memory_order_acquire);
       if (bytes_allocated != 0) {
         res.push_back(bytes_allocated);
       }
     }
-  });
+  }),
+            0);
   return res;
 }
 
@@ -268,20 +269,21 @@ TEST(ThreadSafeArenazSamplerTest, Handle) {
                                                  std::memory_order_relaxed);
 
   bool found = false;
-  sampler.Iterate([&](const ThreadSafeArenaStats& h) {
+  EXPECT_EQ(sampler.Iterate([&](const ThreadSafeArenaStats& h) {
     if (&h == info) {
       EXPECT_EQ(
           h.block_histogram[0].bytes_allocated.load(std::memory_order_relaxed),
           0x12345678);
       EXPECT_EQ(h.weight, kTestStride);
       found = true;
     }
-  });
+  }),
+            0);
   EXPECT_TRUE(found);
 
   h = ThreadSafeArenaStatsHandle();
   found = false;
-  sampler.Iterate([&](const ThreadSafeArenaStats& h) {
+  EXPECT_EQ(sampler.Iterate([&](const ThreadSafeArenaStats& h) {
     if (&h == info) {
       // this will only happen if some other thread has resurrected the info
       // the old handle was using.
@@ -290,7 +292,8 @@ TEST(ThreadSafeArenazSamplerTest, Handle) {
         found = true;
       }
     }
-  });
+  }),
+            0);
   EXPECT_FALSE(found);
 }
 
@@ -424,15 +427,16 @@ TEST(ThreadSafeArenazSamplerTest, InitialBlockReportsZeroUsedAndWasted) {
     char block[kSize];
     google::protobuf::Arena arena(/*initial_block=*/block, /*initial_block_size=*/kSize);
     benchmark::DoNotOptimize(&arena);
-    sampler.Iterate([&](const ThreadSafeArenaStats& h) {
+    EXPECT_EQ(sampler.Iterate([&](const ThreadSafeArenaStats& h) {
       const auto& histbin =
           h.block_histogram[ThreadSafeArenaStats::FindBin(kSize)];
       if (histbin.bytes_allocated.load(std::memory_order_relaxed) == kSize) {
         count_found_allocation++;
         EXPECT_EQ(histbin.bytes_used, 0);
         EXPECT_EQ(histbin.bytes_wasted, 0);
       }
-    });
+    }),
+              0);
   }
   EXPECT_GT(count_found_allocation, 0);
   SetThreadSafeArenazSampleParameter(oldparam);
@@ -491,7 +495,8 @@ TEST(ThreadSafeArenazSamplerTest, MultiThread) {
     if (barrier->Block()) {
       delete barrier;
     }
-    sampler.Iterate([&](const ThreadSafeArenaStats& h) { ++count; });
+    EXPECT_EQ(sampler.Iterate([&](const ThreadSafeArenaStats& h) { ++count; }),
+              0);
     for (int i = 0; i < kNumThreads; i++) {
       threads[i]->Join();
     }
@@ -535,7 +540,8 @@ TEST(ThreadSafeArenazSamplerTest, SampleFirstArena) {
 
   auto count_samples = [&]() {
     int count = 0;
-    sampler.Iterate([&](const ThreadSafeArenaStats& h) { ++count; });
+    EXPECT_EQ(sampler.Iterate([&](const ThreadSafeArenaStats& h) { ++count; }),
+              0);
     return count;
   };
 
@@ -600,7 +606,7 @@ TEST(ThreadSafeArenazSamplerTest, UsedAndWasted) {
   for (int i = 0; i < 1000; ++i) {
     (void)Arena::Create<char>(&arena);
   }
-  sampler.Iterate([&](const ThreadSafeArenaStats& h) {
+  EXPECT_EQ(sampler.Iterate([&](const ThreadSafeArenaStats& h) {
     for (size_t i = 0; i < 3; ++i) {
       constexpr auto kSize =
           google::protobuf::internal::AllocationPolicy::kDefaultStartBlockSize;
@@ -611,7 +617,8 @@ TEST(ThreadSafeArenazSamplerTest, UsedAndWasted) {
                 (kSize << i) - google::protobuf::internal::SerialArena::kBlockHeaderSize);
       EXPECT_EQ(histbin.bytes_wasted, 0);
     }
-  });
+  }),
+            0);
   SetThreadSafeArenazSampleParameter(oldparam);
 }
 #endif  // defined(PROTOBUF_ARENAZ_SAMPLE)