Skip to content

Commit 2a45d14

Browse files
Mark rules_rust as a non-dev dependency
This is a critical step towards public rust_proto_library() support. We previously held this back due to concerns about bloat, but investigation has shown that rules_rust is set up sufficiently that the Rust toolchain will not be installed unless the user affirmatively uses rust_proto_library(), which makes the bloat concerns minimal. PiperOrigin-RevId: 874423531
1 parent 6f67f26 commit 2a45d14

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

MODULE.bazel

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ bazel_dep(name = "rules_kotlin", version = "1.9.6")
4343
bazel_dep(name = "rules_license", version = "1.0.0")
4444
bazel_dep(name = "rules_pkg", version = "1.0.1")
4545
bazel_dep(name = "rules_python", version = "1.6.0")
46+
bazel_dep(name = "rules_rust", version = "0.63.0")
4647

47-
bazel_dep(name = "rules_rust", version = "0.63.0", dev_dependency = True)
4848
bazel_dep(name = "rules_ruby", version = "0.17.3", dev_dependency = True)
4949

5050
# Workaround for https://github.com/bazelbuild/bazel-central-registry/issues/4230
@@ -192,14 +192,14 @@ register_toolchains(
192192
rust = use_extension("@rules_rust//rust:extensions.bzl", "rust", dev_dependency = True)
193193

194194
# As of October 2025, our minimum supported Rust version is 1.79. However, we
195-
# use 1.85.0 here so that we can get some test coverage with edition 2024.
196-
# Cargo and our Bazel WORKSPACE build are both still on edition 2021.
195+
# use 1.85.0 here so that we can get some test coverage with Rust edition 2024.
196+
# Cargo and our Bazel WORKSPACE build are both still on Rust edition 2021.
197197
rust.toolchain(
198198
edition = "2024",
199199
versions = ["1.85.0"],
200200
)
201201

202-
crate = use_extension("@rules_rust//crate_universe:extension.bzl", "crate", dev_dependency = True)
202+
crate = use_extension("@rules_rust//crate_universe:extension.bzl", "crate")
203203
crate.spec(
204204
package = "googletest",
205205
version = ">0.0.0",

0 commit comments

Comments
 (0)