Bug fix for edition 2024 visibility checking. Visibility checking was not properly applied to service method input and output types. This is now applied properly and will error if method input/output types do not have visibility to those messages.

NOTE: this is a potentially breaking change. method input or output types outside of the same file as an RPC service, which have been set to 'local' either explicitly or by default will need to be marked `export` to avoid proto compile errors.  This should be rare as visibility is not widely adopted.
PiperOrigin-RevId: 888762538

Author: protobuf-github-bot

src/google/protobuf/descriptor.cc

@@ -8280,6 +8280,11 @@ void DescriptorBuilder::CrossLinkMethod(MethodDescriptor* method,
                return absl::StrCat("\"", proto.input_type(),
                                    "\" is not a message type.");
              });
+  } else if (!input_type.IsVisibleFrom(file_) &&
+             pool_->enforce_symbol_visibility_) {
+    AddError(method->full_name(), proto,
+             DescriptorPool::ErrorCollector::INPUT_TYPE,
+             [&] { return input_type.GetVisibilityError(file_); });
   } else {
     method->input_type_.Set(input_type.descriptor());
   }
@@ -8302,6 +8307,11 @@ void DescriptorBuilder::CrossLinkMethod(MethodDescriptor* method,
                return absl::StrCat("\"", proto.output_type(),
                                    "\" is not a message type.");
              });
+  } else if (!output_type.IsVisibleFrom(file_) &&
+             pool_->enforce_symbol_visibility_) {
+    AddError(method->full_name(), proto,
+             DescriptorPool::ErrorCollector::OUTPUT_TYPE,
+             [&] { return output_type.GetVisibilityError(file_); });
   } else {
     method->output_type_.Set(output_type.descriptor());
   }

src/google/protobuf/descriptor_unittest.cc

@@ -13905,6 +13905,54 @@ TEST_F(ValidationErrorTest, VisibilityFromLocalExtender) {
       "accessed outside its own file\n");
 }
 
+TEST_F(ValidationErrorTest, VisibilityFromService) {
+  pool_.EnforceSymbolVisibility(true);
+  ASSERT_THAT(ParseAndBuildFile("vis.proto", R"schema(
+        edition = "2024";
+        package vis.test;
+
+        local message LocalMessage {
+        }
+        export message ExportMessage {
+        }
+        )schema"),
+              NotNull());
+
+  ParseAndBuildFileWithErrorSubstr(
+      "service_bad_input.proto",
+      R"schema(
+        edition = "2024";
+        import "vis.proto";
+
+        service MyServiceInput {
+           rpc MyBadMethod(vis.test.LocalMessage)
+             returns (vis.test.ExportMessage) {}
+        }
+      )schema",
+      "service_bad_input.proto: MyServiceInput.MyBadMethod: INPUT_TYPE: Symbol "
+      "\"vis.test.LocalMessage\", "
+      "defined in \"vis.proto\"  is not visible "
+      "from \"service_bad_input.proto\". It is explicitly marked 'local' and "
+      "cannot be accessed outside its own file\n");
+
+  ParseAndBuildFileWithErrorSubstr(
+      "service_bad_return.proto",
+      R"schema(
+        edition = "2024";
+        import "vis.proto";
+
+        service MyServiceReturn {
+           rpc MyBadMethod(vis.test.ExportMessage)
+             returns (vis.test.LocalMessage) {}
+        }
+      )schema",
+      "service_bad_return.proto: MyServiceReturn.MyBadMethod: OUTPUT_TYPE: "
+      "Symbol \"vis.test.LocalMessage\", defined in \"vis.proto\"  is not "
+      "visible from \"service_bad_return.proto\". It is "
+      "explicitly marked 'local' and cannot be accessed outside its own "
+      "file\n");
+}
+
 struct ExtensionDeclarationsTestParams {
   std::string test_name;
 };