Skip to content

Duplicated "Red Sea" label #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wipfli opened this issue Mar 27, 2025 · 6 comments · May be fixed by #489
Open

Duplicated "Red Sea" label #438

wipfli opened this issue Mar 27, 2025 · 6 comments · May be fixed by #489

Comments

@wipfli
Copy link
Collaborator

wipfli commented Mar 27, 2025

Image

https://maps.protomaps.com/#flavorName=light&lang=en&map=8.06/20.465/38.376

@wipfli wipfli linked a pull request May 27, 2025 that will close this issue
@wipfli
Copy link
Collaborator Author

wipfli commented May 27, 2025

There are two labels because there is a multipolygon for the Red Sea which already exists for a long time and has many name translations, and recently someone add a node with place=sea for the Red Sea. https://www.openstreetmap.org/node/11511151629/#map=16/20.33252/38.32328

@bdon
Copy link
Member

bdon commented May 27, 2025

Is this potentially a data issue we should fix in OSM and not something we should fix in the tiling?

@wipfli
Copy link
Collaborator Author

wipfli commented May 27, 2025

I think so. I asked in the changeset which @zstadler made if it would make sense to move that label to the relation

@zstadler
Copy link

zstadler commented May 28, 2025

@wipfli, I have not created this node or the relation. That changeset is just about moving the node from an incorrect location.

Please feel free to add it to the appropriate relation.

@wipfli
Copy link
Collaborator Author

wipfli commented May 28, 2025

Thanks for your fast response @zstadler

If I add the node to the relation and leave the place=sea and name=The Red Sea, I think it will still show up as a separate thing on our map, right @bdon ?

@zstadler
Copy link

I think that in general many OSM place elements are mapped twice: as an area and as a node. This is well captured in the OSM wiki.

IMHO, labels for places should be based only on node places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants