Fix how signals are disconnected in LedDeviceManager (#331)

psieg · psieg · commit 9151a1a1af5c · 2021-09-05T17:17:17.000+02:00
This was introduced in b464611. Instead of disconnecting this=>m_ledDevice, it disconnects this=>*, breaking recovery logic
diff --git a/Software/src/LedDeviceManager.cpp b/Software/src/LedDeviceManager.cpp
@@ -575,8 +575,8 @@ void LedDeviceManager::disconnectSignalSlotsLedDevice()
 		qWarning() << Q_FUNC_INFO << "m_ledDevice == NULL";
 		return;
 	}
-	m_ledDevice->disconnect(this, nullptr, nullptr, nullptr);
-	disconnect(m_ledDevice, nullptr, nullptr, nullptr);
+	disconnect(m_ledDevice, nullptr, this, nullptr);
+	disconnect(this, nullptr, m_ledDevice, nullptr);
 }
 
 void LedDeviceManager::cmdQueueAppend(LedDeviceCommands::Cmd cmd)

Original file line number	Diff line number	Diff line change
`@@ -575,8 +575,8 @@ void LedDeviceManager::disconnectSignalSlotsLedDevice()`
`575`	`575`	`qWarning() << Q_FUNC_INFO << "m_ledDevice == NULL";`
`576`	`576`	`return;`
`577`	`577`	`}`
`578`		`- m_ledDevice->disconnect(this, nullptr, nullptr, nullptr);`
`579`		`- disconnect(m_ledDevice, nullptr, nullptr, nullptr);`
	`578`	`+ disconnect(m_ledDevice, nullptr, this, nullptr);`
	`579`	`+ disconnect(this, nullptr, m_ledDevice, nullptr);`
`580`	`580`	`}`
`581`	`581`
`582`	`582`	`void LedDeviceManager::cmdQueueAppend(LedDeviceCommands::Cmd cmd)`