Harden Go SDK against process crashes and sensitive-data disclosure#185
Merged
Conversation
Validate malformed subscribe event and PAM grant response shapes before type conversion so bad payloads return SDK errors/statuses instead of panicking. Add regression coverage for malformed payloads while preserving valid event behavior.
KGronek-Pubnub
requested review from
Xavrax,
jakub-grzesiowski and
marcin-cebo
as code owners
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
Author
|
@pubnub-release-bot release as v9.0.3 |
Contributor
|
🚀 Release successfully completed 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Add
recoverguards to SDK-owned goroutines (subscribe worker, request workers, job enqueue) so panics fail the request instead of crashing the host process.fix: Replace panic-based
CheckUUIDwithValidateUUIDand validate the UUID inbuildURL, surfacing invalid UUIDs as handled errors;CheckUUIDis kept but deprecated.fix: Harden subscribe response parsing against malformed payloads with checked type assertions that announce a parse error instead of panicking.
fix: Harden Access Manager grant response parsing to validate all fields and return descriptive errors, and fix TTL parsing to accept JSON numbers.
refactor: Return a single generic error on LegacyCryptor decryption failures to prevent padding-oracle-style information disclosure.
refactor: Change redaction of
SecretKeyto show only first 8 characters and total length of the key.