Skip to content

867577 - Fixed unnecessary metadata lookup #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdob merged 1 commit into from
Oct 19, 2012
Merged

867577 - Fixed unnecessary metadata lookup #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions pulp_rpm/src/pulp_rpm/extension/admin/contents.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ def __init__(self, context):

def errata(self, **kwargs):
if kwargs['erratum-id'] is None:
_content_command(self.context, [TYPE_ERRATUM], self.write_erratum, **kwargs)
_content_command(self.context, [TYPE_ERRATUM], **kwargs)
else:
# Collect data
repo_id = kwargs.pop('repo-id')
Expand All @@ -267,15 +267,6 @@ def errata(self, **kwargs):
}
_content_command(self.context, [TYPE_ERRATUM], self.write_erratum_detail, **new_kwargs)

def write_erratum(self, erratum_list):
"""
Write an erratum's metadata out.

:param erratum_list: list of erratum documents; will be of length 1
:type erratum_list: list
"""
self.context.prompt.render_document(erratum_list[0]['metadata'])

def write_erratum_detail(self, erratum_list):
"""
Write an erratum out in a specially formatted way. It is not known why this
Expand All @@ -284,8 +275,7 @@ def write_erratum_detail(self, erratum_list):
:param erratum_list: list one erratum documents; will be of length 1
:type erratum_list: list
"""
erratum = erratum_list[0]
erratum_meta = erratum['metadata']
erratum_meta = erratum_list[0]

self.context.prompt.render_title(_('Erratum: %(e)s') % {'e' : erratum_meta['id']})

Expand Down