Echo to user the service being used

Author: mikkergimenez

lib/vmfloaty/abs.rb

@@ -37,38 +37,39 @@ class ABS
   #     }
   #
 
-  @@active_hostnames = Hash.new
+  @active_hostnames = {}
 
   def self.list_active(verbose, url, _token, user)
-    all_jobs = Array.new()
-    @@active_hostnames = Hash.new
+    all_jobs = []
+    @active_hostnames = {}
 
-    self.get_active_requests(verbose, url, user).each do |reqHash|
-      all_jobs.push(reqHash['request']['job']['id'])
-      @@active_hostnames[reqHash['request']['job']['id']] = reqHash
+    get_active_requests(verbose, url, user).each do |req_hash|
+      all_jobs.push(req_hash['request']['job']['id'])
+      @active_hostnames[req_hash['request']['job']['id']] = req_hash
     end
 
     all_jobs
   end
 
-  def self.get_active_requests verbose, url, user
+  def self.get_active_requests(verbose, url, user)
     conn = Http.get_conn(verbose, url)
     res = conn.get 'status/queue'
     requests = JSON.parse(res.body)
 
-    retVal = []
+    ret_val = []
     requests.each do |req|
-      reqHash = JSON.parse(req)
-      next unless user == reqHash['request']['job']['user']
-      retVal.push(reqHash)
+      req_hash = JSON.parse(req)
+      next unless user == req_hash['request']['job']['user']
+
+      ret_val.push(req_hash)
     end
 
-    retVal
+    ret_val
   end
 
   def self.all_job_resources_accounted_for(allocated_resources, hosts)
-    allocated_host_list = allocated_resources.map {|ar| ar["hostname"] }
-    return (allocated_host_list-hosts).empty?
+    allocated_host_list = allocated_resources.map { |ar| ar['hostname'] }
+    (allocated_host_list - hosts).empty?
   end
 
   def self.delete(verbose, url, hosts, token, user)
@@ -77,19 +78,19 @@ def self.delete(verbose, url, hosts, token, user)
     conn.headers['X-AUTH-TOKEN'] = token if token
 
     puts "Trying to delete hosts #{hosts}" if verbose
-    requests = self.get_active_requests(verbose, url, user)
+    requests = get_active_requests(verbose, url, user)
 
     jobs_to_delete = []
 
-    requests.each do |reqHash|
-      if reqHash['state'] == 'allocated' || reqHash['state'] == 'filled'
-        reqHash['allocated_resources'].each do |vm_name, i|
-          if hosts.include? vm_name["hostname"]
-            if (all_job_resources_accounted_for(job['allocated_resources'], hosts))
-              jobs_to_delete.push(reqHash)
-            else
-              puts "Can't delete #{job_id}: #{hosts} does not include all of #{job['allocated_resources']}"
-            end
+    requests.each do |req_hash|
+      next unless req_hash['state'] == 'allocated' || req_hash['state'] == 'filled'
+
+      req_hash['allocated_resources'].each do |vm_name, _i|
+        if hosts.include? vm_name['hostname']
+          if all_job_resources_accounted_for(job['allocated_resources'], hosts)
+            jobs_to_delete.push(req_hash)
+          else
+            puts "Can't delete #{job_id}: #{hosts} does not include all of #{job['allocated_resources']}"
           end
         end
       end
@@ -98,21 +99,20 @@ def self.delete(verbose, url, hosts, token, user)
     response_body = {}
 
     jobs_to_delete.each do |job|
-      reqObj = {
-        'job_id': job['request']['job']['id'],
-        'hosts': job['allocated_resources'],
+      req_obj = {
+        'job_id' => job['request']['job']['id'],
+        'hosts'  => job['allocated_resources'],
       }
 
-      puts "Deleting #{reqObj}" if verbose
+      puts "Deleting #{req_obj}" if verbose
 
-      res = conn.post 'api/v2/return', reqObj.to_json
+      _ = conn.post 'api/v2/return', req_obj.to_json
       response_body[job_id] = res_body
     end
 
-    return response_body
+    response_body
   end
 
-
   # List available VMs in ABS
   def self.list(verbose, url, os_filter = nil)
     conn = Http.get_conn(verbose, url)
@@ -155,40 +155,37 @@ def self.retrieve(verbose, os_types, token, url, user)
     #   "job": {
     #     "id": "12345",
     #     "tags": {
-    #       "user": "jenkins",
-    #       "jenkins_build_url": "https://jenkins/job/platform_puppet_intn-van-sys_master"
+    #       "user": "username",
     #     }
     #   }
     # }
 
     conn = Http.get_conn(verbose, url)
     conn.headers['X-AUTH-TOKEN'] = token if token
 
-    saved_job_id = Time.now.to_i
+    saved_job_id = DateTime.now.strftime('%Q')
 
-    reqObj = {
+    req_obj = {
       :resources => os_types,
       :job       => {
         :id   => saved_job_id,
         :tags => {
-          :user       => user,
-          :url_string => "floaty://#{user}/#{saved_job_id}",
+          :user => user,
         },
       },
     }
 
     # os_string = os_type.map { |os, num| Array(os) * num }.flatten.join('+')
     # raise MissingParamError, 'No operating systems provided to obtain.' if os_string.empty?
     puts "Requesting VMs with job_id: #{saved_job_id}.  Will retry for up to an hour."
-    res = conn.post 'api/v2/request', reqObj.to_json
+    res = conn.post 'api/v2/request', req_obj.to_json
 
-    i = 0
     retries = 360
 
     raise AuthError, "HTTP #{res.status}: The token provided could not authenticate to the pooler.\n#{res_body}" if res.status == 401
 
     (1..retries).each do |i|
-      queue_place, res_body = check_queue(conn, saved_job_id, reqObj)
+      queue_place, res_body = check_queue(conn, saved_job_id, req_obj)
       return translated(res_body) if res_body
 
       puts "Waiting 10 seconds to check if ABS request has been filled.  Queue Position: #{queue_place}... (x#{i})"
@@ -215,11 +212,11 @@ def self.translated(res_body)
     vmpooler_formatted_body
   end
 
-  def self.check_queue(conn, job_id, reqObj)
+  def self.check_queue(conn, job_id, req_obj)
     queue_info_res = conn.get "/status/queue/info/#{job_id}"
     queue_info = JSON.parse(queue_info_res.body)
 
-    res = conn.post 'api/v2/request', reqObj.to_json
+    res = conn.post 'api/v2/request', req_obj.to_json
 
     unless res.body.empty?
       res_body = JSON.parse(res.body)
@@ -228,7 +225,7 @@ def self.check_queue(conn, job_id, reqObj)
     [queue_info['queue_place'], nil]
   end
 
-  def self.snapshot(verbose, url, hostname, token)
+  def self.snapshot(_verbose, _url, _hostname, _token)
     puts "Can't snapshot with ABS, use '--service vmpooler' (even for vms checked out with ABS)"
   end
 
@@ -247,7 +244,8 @@ def self.summary(verbose, url)
   end
 
   def self.query(verbose, url, hostname)
-    return @@active_hostnames if @@active_hostnames
+    return @active_hostnames if @active_hostnames
+
     puts "For vmpooler/snapshot information, use '--service vmpooler' (even for vms checked out with ABS)"
     conn = Http.get_conn(verbose, url)
 

lib/vmfloaty/pooler.rb

@@ -28,7 +28,7 @@ def self.list_active(verbose, url, token, _user)
     vms
   end
 
-  def self.retrieve(verbose, os_type, token, url, user)
+  def self.retrieve(verbose, os_type, token, url, _user)
     # NOTE:
     #   Developers can use `Utils.generate_os_hash` to
     #   generate the os_type param.

lib/vmfloaty/utils.rb

@@ -88,8 +88,8 @@ def self.pretty_print_hosts(verbose, service, hostnames = [])
         when 'ABS'
           # For ABS, 'hostname' variable is the jobID
           if host_data['state'] == 'allocated' || host_data['state'] == 'filled'
-            host_data['allocated_resources'].each do |vm_name, i|
-              puts "- [JobID:#{host_data['request']['job']['id']}] #{vm_name["hostname"]} (#{vm_name["type"]}) <#{host_data['state']}>"
+            host_data['allocated_resources'].each do |vm_name, _i|
+              puts "- [JobID:#{host_data['request']['job']['id']}] #{vm_name['hostname']} (#{vm_name['type']}) <#{host_data['state']}>"
             end
           end
         when 'Pooler'

spec/vmfloaty/abs_spec.rb

@@ -36,25 +36,25 @@
     end
 
     it 'won\'t delete a job if not all vms are listed' do
-      hosts = ["host1"]
+      hosts = ['host1']
       allocated_resources = [
         {
-          "hostname" => "host1"
+          'hostname' => 'host1',
         },
         {
-          "hostname" => "host2"
-        }
+          'hostname' => 'host2',
+        },
       ]
       expect(ABS.all_job_resources_accounted_for(allocated_resources, hosts)).to eq(false)
 
-      hosts = ["host1", "host2"]
+      hosts = ['host1', 'host2']
       allocated_resources = [
         {
-          "hostname" => "host1"
+          'hostname' => 'host1',
         },
         {
-          "hostname" => "host2"
-        }
+          'hostname' => 'host2',
+        },
       ]
       expect(ABS.all_job_resources_accounted_for(allocated_resources, hosts)).to eq(true)
     end

spec/vmfloaty/nonstandard_pooler_spec.rb

@@ -66,7 +66,7 @@
       @token_status_body_active = <<~BODY
         {
           "ok": true,
-          "user": 'first.last',
+          "user": "first.last",
           "created": "2017-09-18 01:25:41 +0000",
           "last_accessed": "2017-09-21 19:46:25 +0000",
           "reserved_hosts": ["sol10-9", "sol10-11"]
@@ -75,7 +75,7 @@
       @token_status_body_empty = <<~BODY
         {
           "ok": true,
-          "user": 'first.last',
+          "user": "first.last",
           "created": "2017-09-18 01:25:41 +0000",
           "last_accessed": "2017-09-21 19:46:25 +0000",
           "reserved_hosts": []
@@ -88,7 +88,7 @@
         .with(false, @nspooler_url, 'token-value')
         .and_return(JSON.parse(@token_status_body_active))
 
-      list = NonstandardPooler.list_active(false, @nspooler_url, 'token-value')
+      list = NonstandardPooler.list_active(false, @nspooler_url, 'token-value', 'user')
       expect(list).to eql ['sol10-9', 'sol10-11']
     end
   end
@@ -246,7 +246,7 @@
           "sol10-11": {
             "fqdn": "sol10-11.delivery.puppetlabs.net",
             "os_triple": "solaris-10-sparc",
-            "reserved_by_user": 'first.last',
+            "reserved_by_user": "first.last",
             "reserved_for_reason": "testing",
             "hours_left_on_reservation": 29.12
           }

spec/vmfloaty/pooler_spec.rb

@@ -53,7 +53,7 @@
 
       vm_hash = {}
       vm_hash['debian-7-i386'] = 1
-      expect { Pooler.retrieve(false, vm_hash, 'mytokenfile', @vmpooler_url) }.to raise_error(AuthError)
+      expect { Pooler.retrieve(false, vm_hash, 'mytokenfile', @vmpooler_url, 'user') }.to raise_error(AuthError)
     end
 
     it 'retrieves a single vm with a token' do
@@ -63,7 +63,7 @@
 
       vm_hash = {}
       vm_hash['debian-7-i386'] = 1
-      vm_req = Pooler.retrieve(false, vm_hash, 'mytokenfile', @vmpooler_url)
+      vm_req = Pooler.retrieve(false, vm_hash, 'mytokenfile', @vmpooler_url, 'user')
       expect(vm_req).to be_an_instance_of Hash
       expect(vm_req['ok']).to equal true
       expect(vm_req['debian-7-i386']['hostname']).to eq 'fq6qlpjlsskycq6'
@@ -77,7 +77,7 @@
       vm_hash = {}
       vm_hash['debian-7-i386'] = 2
       vm_hash['centos-7-x86_64'] = 1
-      vm_req = Pooler.retrieve(false, vm_hash, 'mytokenfile', @vmpooler_url)
+      vm_req = Pooler.retrieve(false, vm_hash, 'mytokenfile', @vmpooler_url, 'user')
       expect(vm_req).to be_an_instance_of Hash
       expect(vm_req['ok']).to equal true
       expect(vm_req['debian-7-i386']['hostname']).to be_an_instance_of Array