Use consistent Style/NumericPredicate redux

Prior to this commit the codebase used the `zero?` method for comparing
to 0 on some places and not in others.
This commit makes all comparison to zero consistently use the `==`.

Author: Brandon High

lib/vmpooler/pool_manager.rb

@@ -619,7 +619,7 @@ def check_disk_queue(maxloop = 0, loop_delay = 5)
           _check_disk_queue
           sleep(loop_delay)
 
-          unless maxloop.zero?
+          unless maxloop == 0
             break if loop_count >= maxloop
 
             loop_count += 1
@@ -655,7 +655,7 @@ def check_snapshot_queue(maxloop = 0, loop_delay = 5)
           _check_snapshot_queue
           sleep(loop_delay)
 
-          unless maxloop.zero?
+          unless maxloop == 0
             break if loop_count >= maxloop
 
             loop_count += 1
@@ -816,7 +816,7 @@ def check_pool(pool,
             end
             sleep_with_wakeup_events(loop_delay, loop_delay_min, pool_size_change: true, poolname: pool['name'], pool_template_change: true, clone_target_change: true, pool_reset: true)
 
-            unless maxloop.zero?
+            unless maxloop == 0
               break if loop_count >= maxloop
 
               loop_count += 1
@@ -1119,8 +1119,8 @@ def repopulate_pool_vms(pool_name, provider, pool_check_response, pool_size)
       $metrics.gauge("running.#{pool_name}", $redis.scard("vmpooler__running__#{pool_name}"))
 
       if $redis.get("vmpooler__empty__#{pool_name}")
-        $redis.del("vmpooler__empty__#{pool_name}") unless ready.zero?
-      elsif ready.zero?
+        $redis.del("vmpooler__empty__#{pool_name}") unless ready == 0
+      elsif ready == 0
         $redis.set("vmpooler__empty__#{pool_name}", 'true')
         $logger.log('s', "[!] [#{pool_name}] is empty")
       end
@@ -1304,7 +1304,7 @@ def execute!(maxloop = 0, loop_delay = 1)
 
         sleep(loop_delay)
 
-        unless maxloop.zero?
+        unless maxloop == 0
           break if loop_count >= maxloop
 
           loop_count += 1

lib/vmpooler/providers/vsphere.rb

@@ -206,7 +206,7 @@ def wait_for_host_selection(dc, target, maxloop = 0, loop_delay = 1, max_age = 6
           loop_count = 1
           until target.key?(dc) && target[dc].key?('check_time_finished')
             sleep(loop_delay)
-            unless maxloop.zero?
+            unless maxloop == 0
               break if loop_count >= maxloop
 
               loop_count += 1
@@ -217,7 +217,7 @@ def wait_for_host_selection(dc, target, maxloop = 0, loop_delay = 1, max_age = 6
           loop_count = 1
           while Time.now - target[dc]['check_time_finished'] > max_age
             sleep(loop_delay)
-            unless maxloop.zero?
+            unless maxloop == 0
               break if loop_count >= maxloop
 
               loop_count += 1