Skip to content

Commit 586307d

Browse files
authored
Merge pull request #113 from abaco/fix-slice
Fix slice when end index == string length
2 parents a14dc79 + 6a74d00 commit 586307d

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

src/Data/String/CodeUnits.purs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,7 @@ dropWhile p s = drop (countPrefix p s) s
305305
-- | ```
306306
slice :: Int -> Int -> String -> Maybe String
307307
slice b e s = if b' < 0 || b' >= l ||
308-
e' < 0 || e' >= l ||
308+
e' < 0 || e' > l ||
309309
b' > e'
310310
then Nothing
311311
else Just (_slice b e s)

test/Test/Data/String/CodeUnits.purs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -430,6 +430,10 @@ testStringCodeUnits = do
430430
{ actual: SCU.slice 3 6 "purescript"
431431
, expected: Just "esc"
432432
}
433+
assertEqual
434+
{ actual: SCU.slice 3 10 "purescript"
435+
, expected: Just "escript"
436+
}
433437
assertEqual
434438
{ actual: SCU.slice (-4) (-1) "purescript"
435439
, expected: Just "rip"

0 commit comments

Comments
 (0)