You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
coefficient estimation method following DeSoto(2006) (#784)
* function getparams_desoto added to pvsystem module. This commit is just the copy from my previous work, slighty modified for removing the PEP8 warnings.
* getparams_desoto moved from pvsystem to singlediode.
- getparams_desoto renamed in getparams_from_specs
- some initializing values were changed in accordance with Duffie&Beckman2013
* - Modification of getparams_from_specs so as it follows better the procedure of DeSoto&al(2006).
* - Bug corrected in DeSoto(2006) procedure
- test_singlediode completed with a beginning of test_getparams_from_specs
* - test_getparams_from_specs_desoto() finished
- function renamed as above
* Not sure of all changes brought by this commit because of holidays.
- function 'from_epw' added in location
- 1 modification in singlediode
- 1 modification in test_singlediode
* - function '_parse_raw_sam_df' modified. The parser engine is now defined on 'python'. If not the pd.read_csv cannot work with me.
* - ModelChain attribute 'diode_params' transformed from tuple containing pd.Series to DataFrame. Makes the use of diode_params easier for further calculations.
* - singlediode.get_params_from_specs_desoto() output changed. 'a_ref' is changed by 'nNsVth_ref'
* read_epw changed. A line has been added to convert the precipitable water from mm to cm, in order to be compatible with other functions of pvlib
* - read_epw changed. If condition added to make the conversion only in the case of TMY3
* - argument diode_params changed from tuple to pd.DataFrame
* - get_params_from_specs_desoto removed from singlediode.py
* - function fit_sdm_desoto added. Still need to be formatted
* - change on type of self.diode_params removed. Go check on branch diode_params_in_df for seeing it
* - Function 'fit_sdm_desoto' cleaned and variables names named as in 'fit_sdm_cec_sam'
* - all changes made on other files than ivtools.py removed (cleaning for comparing before PR)
* - other differences cleaned
* - renaming of one variable and minor documentation modifications
* - Beginning of writting of test_fit_sdm_desoto. Coverage around 90-95% I think
* -minor format changes
* - changes made according to feedbacks of markcampanelli
* - some cleaning on fit_sdm_desoto to make it more readable
- tests completed
* - minor code cleaning
* - check on importation of scipy removed
* - minor cleaning
* - attempt to reach 100% coverage
* - description added in docs/sphinx/source/whatsnew/v0.7.0.rst
* - changes made according to cwhanse review. Except alpha_sc and beta_voc still in %/K
* - minor correction and adaptation of test
* - sign correction on 3rd equation
* - changes on units of alpha_sc and beta_voc inputs. Now in A/K and V/K rather than %/K.
- 'celltype' input replaced by EgRef and dEgdT, with values of Si as default
* - other line of test added for better coverage
* - some changes to try feedbacks of cwhanse and markcampanelli, not finished
* -OptimizeResult added in output
- solver_method removed
- docstring modified
- result.message included in message raised by RuntimeError
* - includes all feedbacks made on the 21/10, except moving of pv_fct() to the module level
* - pv_fct moved out of the fit_sdm_desoto function and renamed in _system_of_equations
* - minor modification: Boltzmann k given in specs to avoid import of scipy in _system_of_equations
* - cleaning and minor modifications to docstring
* - references added to docstring in _system_of_equations
* - modification for removing last lint error
* - modification for removing last lint error
* - modification for removing lint error
* - integration of adriesse suggestions
* - adding of tylunel to the list of contributors
* - adding of mark requires_scipy
0 commit comments