Skip to content

Commit e3baa12

Browse files
authored
Fix conditional dependency on dataclasses (#1422)
* better conditional dependency on dataclasses * whatsnew
1 parent 27cba7a commit e3baa12

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

docs/sphinx/source/whatsnew/v0.9.1.rst

+2
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,8 @@ Documentation
6464
Requirements
6565
~~~~~~~~~~~~
6666
* numpy >= 1.16.0 is now required for all python versions. (:pull:`1400`)
67+
* Fix an installation issue with ``dataclasses`` on python 3.6
68+
(:issue:`1302`, :pull:`1422`)
6769

6870

6971
Contributors

setup.py

+2-5
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,8 @@
4343
'pytz',
4444
'requests',
4545
'scipy >= 1.2.0',
46-
'h5py']
47-
48-
# include dataclasses as a dependency only on python 3.6
49-
if sys.version_info.major == 3 and sys.version_info.minor == 6:
50-
INSTALL_REQUIRES.append('dataclasses')
46+
'h5py',
47+
'dataclasses; python_version < "3.7"']
5148

5249
TESTS_REQUIRE = ['nose', 'pytest', 'pytest-cov', 'pytest-mock',
5350
'requests-mock', 'pytest-timeout', 'pytest-rerunfailures',

0 commit comments

Comments
 (0)