Skip to content

v0.9.1 release planning #1424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
10 of 14 tasks
cwhanse opened this issue Mar 14, 2022 · 11 comments · Fixed by #1431
Closed
10 of 14 tasks

v0.9.1 release planning #1424

cwhanse opened this issue Mar 14, 2022 · 11 comments · Fixed by #1431
Labels
Milestone

Comments

@kandersolar kandersolar added this to the 0.9.1 milestone Mar 14, 2022
This was referenced Mar 22, 2022
@wholmgren
Copy link
Member

Given the current status of issues/prs, I suggest that we pick a day to release and go with whatever is available on that day. @kanderso-nrel already started the Finalize PR, which implies that he's volunteered to tag as well :) In that case, up to Kevin on schedule.

@kandersolar
Copy link
Member

Sure, I can tag. Sometime next week, maybe March 29?

Given its recent progress it'd be a bit of a shame to not include #1251 IMHO. #1345 would be good too (thanks @cwhanse for pointing it out). I've not updated that file before but I'm willing to figure it out if others are not actively excited to do it this time.

We are not addressing any part of #1403 in 0.9.1, correct?

@cwhanse
Copy link
Member Author

cwhanse commented Mar 24, 2022

We are not addressing any part of #1403 in 0.9.1, correct?

I started on #1403 and got discouraged by the apparent breadth of functions and methods it would touch. Maybe it would be better to do incremental PRs for that issue.

@mikofski
Copy link
Member

pick a day to release

I would ❤️ to have a regular release schedule, like every 3-6 months. This is an essential component of agile

@mikofski
Copy link
Member

Given its recent progress it'd be a bit of a shame to not include...

I think the solution is not to delay the release but to have more often releases, but I realize it's a balancing act.

@cwhanse
Copy link
Member Author

cwhanse commented Mar 29, 2022

Each release leaves me with a list of open issues that I would like to see closed. More frequent releases = more motivation to work on those issues :)

@mikofski
Copy link
Member

@kanderso-nrel and others, shall we add "auto-bot" to conda forge? Create an issue with this in the title only?
@conda-forge-admin,please add bot automerge I think that's it

@wholmgren
Copy link
Member

In my experience, the conda forge bots are only ok at picking up changes to the dependencies. We could add automerge but I think we'd still want to manually review the work and possibly need to update recipes and issue new builds.

@mikofski
Copy link
Member

mikofski commented Mar 30, 2022

we'd still want to manually review the work and possibly need to update recipes and issue new builds

I think there's a different bot for detecting version changes, not automerge-bot, which I think pushes a new release automatically if the tests all pass. That's been my experience with the dulwich-feedstock.

I believe the one we might want then is regro/cf-autotick-bot, which I thought would automatically already be part of the pvlib python feedstock, but is it possible that pvlib predates the autotick-bot? TBH, I don't understand how to add this functionality if it's not already part of the feedstock, I think if we want this feature (which I'd advise) we should seek help on their google group? I notice that SolarForecastArbiter was forked by the autotick-bot, but pvlib is not

IDK, maybe I'm missing something. Are any of you getting PR's from autotick-bot alerting you about a possible new version of pvlib upstream? I don't see it, but I think we should be. It broke somewhere between v0.8 and v0.9:
image

@wholmgren
Copy link
Member

From conda-forge/solarforecastarbiter-feedstock#17 (comment)

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

It's better than nothing, but it does require review. I don't remember anything about the pvlib feedstock setup, so best to search their docs and/or ping their bot team.

@mikofski
Copy link
Member

Maybe last bullet is a clue

needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants