Skip to content

Temperature model parameter translation #1442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adriesse opened this issue Apr 13, 2022 · 6 comments · Fixed by #1463
Closed

Temperature model parameter translation #1442

adriesse opened this issue Apr 13, 2022 · 6 comments · Fixed by #1463
Milestone

Comments

@adriesse
Copy link
Member

adriesse commented Apr 13, 2022

Is your feature request related to a problem? Please describe.
The simple temperature models in pvlib are all very similar but their parameters are not interchangeable.

Describe the solution you'd like
This feature will provide a means to translate parameters between these models: Faiman, SAPM, PVsyst & NOCT SAM.

Additional context
Details of the methods were presented at IEEE PVSC 2022. A pre-print version of the paper can be downloaded from here:

https://www.researchgate.net/publication/361463601_PV_Module_Operating_Temperature_Model_Equivalence_and_Parameter_Translation

@adriesse
Copy link
Member Author

I've created a PR for a substantial addition to the temperature module. It is in the form of a class with various set* and get* methods to interact with different model parameters. I'd like to get some feedback and/or reactions on the design before launching into doc strings and tests. The class doc string currently has some code snippets to illustrate usage.

Scientific comments could go here and code comments in the PR?

@mikofski
Copy link
Member

This is an interesting idea. Does it only refer to Faiman and PVsyst? Or also Fuentes or SAPM?

perhaps a write up in a new temperature section of the user guide, on the PVPMC website, or in the pvlib GH wiki would be useful to describe in more detail how these models are mathematically and scientifically similar or different would be helpful in explaining why we need a function or class to interpret them and use them interchangeably?

@adriesse
Copy link
Member Author

I updated the current scope in the opening description: Faiman, SAPM, PVsyst & NOCT SAM. The upcoming IEEE PVSC paper should answer a lot of your questions and we can see after the event how much of that content needs repeating in other forms.

@adriesse
Copy link
Member Author

adriesse commented Jun 22, 2022

I've inserted a link to the pre-print version of the paper in the issue description.

@kandersolar kandersolar added this to the 0.9.3 milestone Sep 1, 2022
@kandersolar
Copy link
Member

kandersolar commented Sep 9, 2022

@adriesse I've been led to understand that this feature and #1523 are the first of several planned additions to pvlib. What do you think about opening (preliminary) issues for those future additions now? For one it's just interesting to see what's coming down the pipe, but it might also be useful context for other additions in the meantime.

@adriesse
Copy link
Member Author

adriesse commented Sep 9, 2022

That's a good question but hard to answer. We're doing model development and the output can go into functions, notebooks, reports and papers and can include data files. I could try to open PR's earlier, but that's probably not a full solution for coordinated development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants