Skip to content

remove module from singlediode function arguments #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wholmgren opened this issue Jun 24, 2016 · 1 comment · Fixed by #202
Closed

remove module from singlediode function arguments #200

wholmgren opened this issue Jun 24, 2016 · 1 comment · Fixed by #202
Labels
Milestone

Comments

@wholmgren
Copy link
Member

I'm just now realizing that the module argument to our singlediode function is nearly pointless. module['V_oc_ref'] is used to set the initial guess for the p_mp numerical solution, and I'm pretty sure that it can be replaced with the calculated v_oc. This will simplify the api and bring us back into consistency with the matlab library.

@wholmgren wholmgren added the api label Jun 24, 2016
@wholmgren wholmgren added this to the 0.4.0 milestone Jun 24, 2016
@cwhanse
Copy link
Member

cwhanse commented Jun 24, 2016

I agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants