You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
I think the documentation for the spectral_factor_sapm function is lacking detail. There is a comment directing users to sapm() for further detail, but actually I'm not 100% sure what that is--- is it pvsystem.sapm?
Describe the solution you'd like
I'd like to update the docs to a similar level of detail as the other spectral_factor docs. At a minimum:
hyperlink the sapm module referenced currently (this page?)
Add more information on the model development and other context, including the equation
Describe alternatives you've considered
I understand that the SAPM air mass function is not commonly used nowadays, but as it is still in pvlib I think it would still add value to substantiate the docs where the function is found. I'd like to create a PR for these changes but I think I should only go ahead if I get a couple of +1s for this agreeing it'd add value.
Any other suggestions and feedback always more than welcome.
The text was updated successfully, but these errors were encountered:
RDaxini
changed the title
update spectral_factor_sapm
update spectral_factor_sapm docs
Jul 2, 2024
Is your feature request related to a problem? Please describe.
I think the documentation for the spectral_factor_sapm function is lacking detail. There is a comment directing users to
sapm()
for further detail, but actually I'm not 100% sure what that is--- is itpvsystem.sapm
?Describe the solution you'd like
I'd like to update the docs to a similar level of detail as the other
spectral_factor
docs. At a minimum:Describe alternatives you've considered
I understand that the SAPM air mass function is not commonly used nowadays, but as it is still in pvlib I think it would still add value to substantiate the docs where the function is found. I'd like to create a PR for these changes but I think I should only go ahead if I get a couple of +1s for this agreeing it'd add value.
Any other suggestions and feedback always more than welcome.
The text was updated successfully, but these errors were encountered: