Skip to content

Create calculate_avg_photon_energy function #2135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RDaxini opened this issue Jul 18, 2024 · 2 comments · Fixed by #2140
Closed

Create calculate_avg_photon_energy function #2135

RDaxini opened this issue Jul 18, 2024 · 2 comments · Fixed by #2140
Milestone

Comments

@RDaxini
Copy link
Contributor

RDaxini commented Jul 18, 2024

I think a function to calculate the average photon energy (APE) using spectral irradiance data as an input would be a useful feature in pvlib.

Additional context
This would support PR #2126. While there are some discussions ongoing regarding that PR in Issue #2065, I think this may still be a useful feature in pvlib anyway regardless of the outcome of that PR.

The function would be in pvlib/spectrum/spectral_irradiance.py following the resolution of #2125 (I will create a PR for that soon issue soon)

I am wondering what people think about naming this function. Possibilities:

calculate_avg_photon_energy
calculate_average_photon_energy
calculate_ape
Switch "calculate" for "get" or "calc", or just omit this first word entirely?
Alternatives?

Any other thoughts on this?

@echedey-ls
Copy link
Contributor

or just omit this first word entirely?

+1 for average_photon_energy

@AdamRJensen
Copy link
Member

or just omit this first word entirely?

+1 for average_photon_energy

+2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants