Skip to content

use generic broadband AOD in Bird model instead of only Bird-Hulstrom approximation #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mikofski opened this issue Jun 30, 2017 · 1 comment
Labels
Milestone

Comments

@mikofski
Copy link
Member

Probem

  1. Currently the Bird clear sky model only takes arguments for aod380, aod500 and uses the Bird-Hulstrom approximation for broadband AOD.
  2. There are other broadband approximations that might be better such as Molineaux approximation which is what Ineichen suggests for simplified Solis.
  3. The signature of the arguments for the Bird model are different from the Simplified Solis, would be better if they were consistent, so instead of asking for two AOD arguments, the Bird model should only ask for aod_bb. Huh, should we update the Solis also, since it actually asks for aod700?

Solution

  1. Just replace the two AOD arguments in Bird with a single broadband AOD argument
  2. replace the calculation of bird_hulstrom broadband approximation with the same argument from (1)
  3. replace the variable occurances everywhere for bird_hulstrom with aod_bb.
  4. update the documentation
  5. maybe consider changing aod700 argument/variable in solis to aod_bb

related to #276, #269 and #278

@wholmgren
Copy link
Member

I support @mikofski's proposed changes to the bird clear sky model implementation. Let's make sure the clear sky model's documentation makes reference to the bird_hulstrom function.

I think we should keep using aod700 in simplified solis, at least for now.

@wholmgren wholmgren added the api label Jun 30, 2017
@wholmgren wholmgren added this to the Someday milestone Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants