You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the Bird clear sky model only takes arguments for aod380, aod500 and uses the Bird-Hulstrom approximation for broadband AOD.
There are other broadband approximations that might be better such as Molineaux approximation which is what Ineichen suggests for simplified Solis.
The signature of the arguments for the Bird model are different from the Simplified Solis, would be better if they were consistent, so instead of asking for two AOD arguments, the Bird model should only ask for aod_bb. Huh, should we update the Solis also, since it actually asks for aod700?
Solution
Just replace the two AOD arguments in Bird with a single broadband AOD argument
replace the calculation of bird_hulstrom broadband approximation with the same argument from (1)
replace the variable occurances everywhere for bird_hulstrom with aod_bb.
update the documentation
maybe consider changing aod700 argument/variable in solis to aod_bb
I support @mikofski's proposed changes to the bird clear sky model implementation. Let's make sure the clear sky model's documentation makes reference to the bird_hulstrom function.
I think we should keep using aod700 in simplified solis, at least for now.
Probem
aod380
,aod500
and uses the Bird-Hulstrom approximation for broadband AOD.aod_bb
. Huh, should we update the Solis also, since it actually asks foraod700
?Solution
bird_hulstrom
broadband approximation with the same argument from (1)bird_hulstrom
withaod_bb
.aod700
argument/variable insolis
toaod_bb
related to #276, #269 and #278
The text was updated successfully, but these errors were encountered: