Skip to content

Stop bundling the SAM modules/inverters database with pvlib #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Peque opened this issue Aug 23, 2019 · 0 comments
Open

Stop bundling the SAM modules/inverters database with pvlib #769

Peque opened this issue Aug 23, 2019 · 0 comments

Comments

@Peque
Copy link
Contributor

Peque commented Aug 23, 2019

As suggested by @wholmgren.

A function could be used to download the files to a local hidden directory.

@cwhanse pointed out that the file may change upstream. I think we could use a URL that includes the commit hash (example) to avoid fetching the wrong version. Also, if you fear they may force-push changes and remove that reference, then I suggest you fork the project in pvlib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant