Skip to content

Redefining built-in 'input' with tools._scalar_out() and tools._array_out() #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
CameronTStark opened this issue Oct 23, 2019 · 0 comments · Fixed by #800
Closed

Redefining built-in 'input' with tools._scalar_out() and tools._array_out() #799

CameronTStark opened this issue Oct 23, 2019 · 0 comments · Fixed by #800

Comments

@CameronTStark
Copy link
Contributor

Describe the bug

The built-in function input() is being redefined in these two functions in tools. There is currently no functional issue but to avoid future linting/formatting issues I'd suggest changing the name.

To Reproduce
Steps to reproduce the behavior:

  1. Open pvlib.tools with an IDE
  2. Review the code for _scalar_out() and _array_out() with a linter turned on.

I'll create a PR addressing this specifically.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change tools._scalar_out/_array_out arg name to avoid collision with builtin input function
1 participant
@CameronTStark