Skip to content

Add a plotting wrapper that make it easy to get high-quality plots #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
UGuntupalli opened this issue Jan 20, 2020 · 3 comments
Closed

Comments

@UGuntupalli
Copy link

Is your feature request related to a problem? Please describe.
pvlib is great and thanks to all the great contributions that exist. I don't necessarily see this as a problem, but rather an enhancement to have a plotting wrapper library based on plotly/ bokeh that makes it easy to prepare high quality plots instead of using matlplotlib. I am happy to take a first pass.

Describe the solution you'd like
Ideal solution would include good wrappers for generally used plotting functions like scatter plot, bar chart, line chart etc. with options to customize to allow the user to customize as needed, but also cut down up-front work in preparing the figure.

Describe alternatives you've considered
This is just an enhancement, so I have not considered any alternatives, open to suggestions/ feedback.

@kandersolar
Copy link
Member

Would these be new ModelChain methods that make plots based on the modelchain's attributes? Or more general functions where you pass in the datasets of interest? I think it might be helpful to show some pseudocode usage examples of what you're imagining, since right now your proposal doesn't mention any specifics about how this code relates to pvlib :)

At a high level I'd guess that the set of plots that pvlib users generate is going to be pretty varied, so any pvlib plotting functions would have to be very general and flexible to get much use. If that's the case then I'm not sure what value they'd bring over the functions in the base plotting libraries themselves. @UGuntupalli what do you think?

@mikofski
Copy link
Member

How about putting an example of making a plotly or bokeh plot in the new examples gallery?

Here are my concerns about your proposal, IIUC:

  • I believe that bokeh and plotly dependencies will be undesirable for most users
  • IMO mpl and seaborn actually do make really excellent high-quality, publishable plots, and pandas plotting ability makes generating these already mostly builtin. I disagree that bokeh and plotly are higher quality at least for publications. However I do agree that bokeh and plotly, and possibly altair, vega, and vega-lite might be better for websites, because those plotting libraries are more interactive and come with JS hooks -- but I think examples in the gallery will better serve users interested in making plots with these non-mpl/seaborn libs
  • if the plotting wrappers are untestable, I'm concerned it will lower our coverage.

I'm sorry this is sounding negative. I really like this idea, and I do really encourage you to contribute, but IMHO I think this idea would be better in the examples gallery. Thanks

@wholmgren
Copy link
Member

Thanks @UGuntupalli for the idea and your efforts in #871. It looks like this is going to be too much of an infrastructure challenge for including in pvlib, but I do encourage you to pursue the examples elsewhere and advertise them to the pvlib community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants