-
Notifications
You must be signed in to change notification settings - Fork 1.1k
irradiance.detect_clearsky: possibly redundant input 'times' #954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
measured and clear sky are allowed to be arrays |
The chances of having measured and clear sky without time indexes are pretty slim though, aren't they? |
I agree and support the API change. |
#1074 changed Recommend closing this issue. |
Fine with me to keep it open in an effort to simplify API or to close in an effort to clean the issues board. Either way not going into 0.9, so I removed the milestone. |
irradiance.detect_clearsky
expects measured and clear-sky GHI to be input as Series, and has an inputtimes
as a DatetimeIndex.pvlib-python/pvlib/clearsky.py
Line 629 in 85eeaa7
What is the use case for having
times
as a separate input? Should the function instead usemeasured.index
?The text was updated successfully, but these errors were encountered: