From 125e06ab5c98e38564674f3f7857cdf7a6316b87 Mon Sep 17 00:00:00 2001 From: Hopwood Date: Fri, 7 May 2021 16:18:41 -0400 Subject: [PATCH 1/5] removed kwargs in calcparams_desoto, calcparams_cec, and sapm --- pvlib/pvsystem.py | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/pvlib/pvsystem.py b/pvlib/pvsystem.py index f6901617c3..a7dafbc701 100644 --- a/pvlib/pvsystem.py +++ b/pvlib/pvsystem.py @@ -379,7 +379,7 @@ def get_iam(self, aoi, iam_model='physical'): for array, aoi in zip(self.arrays, aoi)) @_unwrap_single_value - def calcparams_desoto(self, effective_irradiance, temp_cell, **kwargs): + def calcparams_desoto(self, effective_irradiance, temp_cell): """ Use the :py:func:`calcparams_desoto` function, the input parameters and ``self.module_parameters`` to calculate the @@ -393,9 +393,6 @@ def calcparams_desoto(self, effective_irradiance, temp_cell, **kwargs): temp_cell : float or Series or tuple of float or Series The average cell temperature of cells within a module in C. - **kwargs - See pvsystem.calcparams_desoto for details - Returns ------- See pvsystem.calcparams_desoto for details @@ -420,7 +417,7 @@ def calcparams_desoto(self, effective_irradiance, temp_cell, **kwargs): ) @_unwrap_single_value - def calcparams_cec(self, effective_irradiance, temp_cell, **kwargs): + def calcparams_cec(self, effective_irradiance, temp_cell): """ Use the :py:func:`calcparams_cec` function, the input parameters and ``self.module_parameters`` to calculate the @@ -434,9 +431,6 @@ def calcparams_cec(self, effective_irradiance, temp_cell, **kwargs): temp_cell : float or Series or tuple of float or Series The average cell temperature of cells within a module in C. - **kwargs - See pvsystem.calcparams_cec for details - Returns ------- See pvsystem.calcparams_cec for details @@ -501,7 +495,7 @@ def calcparams_pvsyst(self, effective_irradiance, temp_cell): ) @_unwrap_single_value - def sapm(self, effective_irradiance, temp_cell, **kwargs): + def sapm(self, effective_irradiance, temp_cell): """ Use the :py:func:`sapm` function, the input parameters, and ``self.module_parameters`` to calculate @@ -515,9 +509,6 @@ def sapm(self, effective_irradiance, temp_cell, **kwargs): temp_cell : float or Series or tuple of float or Series The average cell temperature of cells within a module in C. - kwargs - See pvsystem.sapm for details - Returns ------- See pvsystem.sapm for details From 35bdcb529f7c795e55d1efa5472bc47a6345e509 Mon Sep 17 00:00:00 2001 From: Hopwood Date: Fri, 7 May 2021 16:35:50 -0400 Subject: [PATCH 2/5] updated whatsnew file --- docs/sphinx/source/whatsnew/v0.9.0.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/sphinx/source/whatsnew/v0.9.0.rst b/docs/sphinx/source/whatsnew/v0.9.0.rst index 65af5620d0..2b2c9af9a7 100644 --- a/docs/sphinx/source/whatsnew/v0.9.0.rst +++ b/docs/sphinx/source/whatsnew/v0.9.0.rst @@ -119,6 +119,9 @@ Bug fixes * Update GFS product names for GFS v16. (:issue:`1202`, :pull:`1203`) * Corrected methodology error in :py:func:`~pvlib.scaling.wvm`. Tracks with fix in PVLib for MATLAB. (:issue:`1206`, :pull:`1213`) +* Removed the **kwargs parameters from :py:meth:`~pvlib.pvsystem.sapm` and + :py:meth:`~pvlib.pvsystem.calcparams_desoto` and + :py:meth:`~pvlib.pvsystem.calcparams_cec` (:issue:`1118`, :pull:`xxxx`) Testing ~~~~~~~ From d5b97cd2f3a4cf706f6c8f07c36f7a6aa3a56463 Mon Sep 17 00:00:00 2001 From: Hopwood Date: Fri, 7 May 2021 16:36:47 -0400 Subject: [PATCH 3/5] update whatsnew file with PR number --- docs/sphinx/source/whatsnew/v0.9.0.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/sphinx/source/whatsnew/v0.9.0.rst b/docs/sphinx/source/whatsnew/v0.9.0.rst index 2b2c9af9a7..d319cdb8a4 100644 --- a/docs/sphinx/source/whatsnew/v0.9.0.rst +++ b/docs/sphinx/source/whatsnew/v0.9.0.rst @@ -121,7 +121,7 @@ Bug fixes fix in PVLib for MATLAB. (:issue:`1206`, :pull:`1213`) * Removed the **kwargs parameters from :py:meth:`~pvlib.pvsystem.sapm` and :py:meth:`~pvlib.pvsystem.calcparams_desoto` and - :py:meth:`~pvlib.pvsystem.calcparams_cec` (:issue:`1118`, :pull:`xxxx`) + :py:meth:`~pvlib.pvsystem.calcparams_cec` (:issue:`1118`, :pull:`1222`) Testing ~~~~~~~ From 545595dc25bae1f067a7e2045df206a253cb1150 Mon Sep 17 00:00:00 2001 From: MichaelHopwood Date: Tue, 11 May 2021 13:27:29 -0400 Subject: [PATCH 4/5] moved note in whatsnew file --- docs/sphinx/source/whatsnew/v0.9.0.rst | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/sphinx/source/whatsnew/v0.9.0.rst b/docs/sphinx/source/whatsnew/v0.9.0.rst index d319cdb8a4..b5266c7e25 100644 --- a/docs/sphinx/source/whatsnew/v0.9.0.rst +++ b/docs/sphinx/source/whatsnew/v0.9.0.rst @@ -45,6 +45,10 @@ Breaking changes ``surface_azimuth`` are now required parameters for :py:func:`pvlib.modelchain.basic_chain` (:issue:`1028`, :pull:`1181`) +* Removed the **kwargs parameters from :py:meth:`~pvlib.pvsystem.sapm` and + :py:meth:`~pvlib.pvsystem.calcparams_desoto` and + :py:meth:`~pvlib.pvsystem.calcparams_cec` (:issue:`1118`, :pull:`1222`) + Deprecations ~~~~~~~~~~~~ @@ -119,9 +123,6 @@ Bug fixes * Update GFS product names for GFS v16. (:issue:`1202`, :pull:`1203`) * Corrected methodology error in :py:func:`~pvlib.scaling.wvm`. Tracks with fix in PVLib for MATLAB. (:issue:`1206`, :pull:`1213`) -* Removed the **kwargs parameters from :py:meth:`~pvlib.pvsystem.sapm` and - :py:meth:`~pvlib.pvsystem.calcparams_desoto` and - :py:meth:`~pvlib.pvsystem.calcparams_cec` (:issue:`1118`, :pull:`1222`) Testing ~~~~~~~ From b71303cf28baa4a8eb611478b34ae7adf166cab6 Mon Sep 17 00:00:00 2001 From: Michael Hopwood Date: Wed, 12 May 2021 09:00:19 -0400 Subject: [PATCH 5/5] Update v0.9.0.rst --- docs/sphinx/source/whatsnew/v0.9.0.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/sphinx/source/whatsnew/v0.9.0.rst b/docs/sphinx/source/whatsnew/v0.9.0.rst index b5266c7e25..bb5704375e 100644 --- a/docs/sphinx/source/whatsnew/v0.9.0.rst +++ b/docs/sphinx/source/whatsnew/v0.9.0.rst @@ -45,9 +45,9 @@ Breaking changes ``surface_azimuth`` are now required parameters for :py:func:`pvlib.modelchain.basic_chain` (:issue:`1028`, :pull:`1181`) -* Removed the **kwargs parameters from :py:meth:`~pvlib.pvsystem.sapm` and - :py:meth:`~pvlib.pvsystem.calcparams_desoto` and - :py:meth:`~pvlib.pvsystem.calcparams_cec` (:issue:`1118`, :pull:`1222`) +* Removed the ``**kwargs`` parameters from :py:meth:`~pvlib.pvsystem.PVSystem.sapm` and + :py:meth:`~pvlib.pvsystem.PVSystem.calcparams_desoto` and + :py:meth:`~pvlib.pvsystem.PVSystem.calcparams_cec` (:issue:`1118`, :pull:`1222`) Deprecations