From 633b2402b7b2ca92fab3923510fb2aa8fc51bca6 Mon Sep 17 00:00:00 2001 From: RoyCoding8 Date: Fri, 25 Mar 2022 10:43:20 +0530 Subject: [PATCH 1/6] Update plot_singlediode.py MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Changed the unit from C to degree C (°C) --- docs/examples/iv-modeling/plot_singlediode.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/examples/iv-modeling/plot_singlediode.py b/docs/examples/iv-modeling/plot_singlediode.py index c92d5e999e..2fcdb7a944 100644 --- a/docs/examples/iv-modeling/plot_singlediode.py +++ b/docs/examples/iv-modeling/plot_singlediode.py @@ -103,7 +103,7 @@ for i, case in conditions.iterrows(): label = ( "$G_{eff}$ " + f"{case['Geff']} $W/m^2$\n" - "$T_{cell}$ " + f"{case['Tcell']} $C$" + "$T_{cell}$ " + f"{case['Tcell']} $°C$" ) plt.plot(curve_info['v'][i], curve_info['i'][i], label=label) v_mp = curve_info['v_mp'][i] From 94bbb6efe556276e704b5ddb155bd6b9e0ced724 Mon Sep 17 00:00:00 2001 From: RoyCoding8 Date: Fri, 25 Mar 2022 14:13:34 +0530 Subject: [PATCH 2/6] Update plot_singlediode.py Changed to LaTeX \degree symbol in matplotlib which avoids any encoding issues with using Unicode characters. --- docs/examples/iv-modeling/plot_singlediode.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/examples/iv-modeling/plot_singlediode.py b/docs/examples/iv-modeling/plot_singlediode.py index 2fcdb7a944..e9085b3341 100644 --- a/docs/examples/iv-modeling/plot_singlediode.py +++ b/docs/examples/iv-modeling/plot_singlediode.py @@ -103,7 +103,7 @@ for i, case in conditions.iterrows(): label = ( "$G_{eff}$ " + f"{case['Geff']} $W/m^2$\n" - "$T_{cell}$ " + f"{case['Tcell']} $°C$" + "$T_{cell}$ " + f"{case['Tcell']} $\\degree C$" ) plt.plot(curve_info['v'][i], curve_info['i'][i], label=label) v_mp = curve_info['v_mp'][i] From efcf2aa8e1f1e819093455552f67af0020ea2287 Mon Sep 17 00:00:00 2001 From: RoyCoding8 Date: Fri, 25 Mar 2022 20:45:09 +0530 Subject: [PATCH 3/6] Update v0.9.1.rst Added name to the contributors' list --- docs/sphinx/source/whatsnew/v0.9.1.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/sphinx/source/whatsnew/v0.9.1.rst b/docs/sphinx/source/whatsnew/v0.9.1.rst index f7566e691a..bd3137b5bb 100644 --- a/docs/sphinx/source/whatsnew/v0.9.1.rst +++ b/docs/sphinx/source/whatsnew/v0.9.1.rst @@ -85,3 +85,4 @@ Contributors * Jack Kelly (:ghuser:`JackKelly`) * Somasree Majumder(:ghuser:`soma2000-lang`) * Naman Priyadarshi (:ghuser:`Naman-Priyadarshi`) +* Shashwata Roy (:ghuser: `RoyCoding8`) From d885d59de032c4fa2f2a30556ed35b3e2c595a2a Mon Sep 17 00:00:00 2001 From: RoyCoding8 Date: Fri, 25 Mar 2022 20:53:35 +0530 Subject: [PATCH 4/6] Update v0.9.1.rst --- docs/sphinx/source/whatsnew/v0.9.1.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/sphinx/source/whatsnew/v0.9.1.rst b/docs/sphinx/source/whatsnew/v0.9.1.rst index bd3137b5bb..8cdd5b4642 100644 --- a/docs/sphinx/source/whatsnew/v0.9.1.rst +++ b/docs/sphinx/source/whatsnew/v0.9.1.rst @@ -64,6 +64,7 @@ Documentation * Fix some typos (:pull:`1414`) * Clarify the descriptions of ``delta_t`` in several solar position functions (:pull:`1429`) +* Changed $C$ to $\\degree C$ in the plot_singlediode.py file (:pull:`1434`) Requirements ~~~~~~~~~~~~ From b8eef9841efbbe905d6181ebdbf07b39d1e4706f Mon Sep 17 00:00:00 2001 From: RoyCoding8 Date: Tue, 26 Apr 2022 12:03:25 +0530 Subject: [PATCH 5/6] Update plot_ghi_transposition.py Made some changes in labels and comments; deleted a variable which is not required --- .../irradiance-transposition/plot_ghi_transposition.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/docs/examples/irradiance-transposition/plot_ghi_transposition.py b/docs/examples/irradiance-transposition/plot_ghi_transposition.py index 5eeb27ca36..9515fa2b82 100644 --- a/docs/examples/irradiance-transposition/plot_ghi_transposition.py +++ b/docs/examples/irradiance-transposition/plot_ghi_transposition.py @@ -18,11 +18,10 @@ from matplotlib import pyplot as plt # For this example, we will be using Golden, Colorado -tz = 'MST' lat, lon = 39.755, -105.221 # Create location object to store lat, lon, timezone -site = location.Location(lat, lon, tz=tz) +site = location.Location(lat, lon, tz='MST') # Calculate clear-sky GHI and transpose to plane of array @@ -52,7 +51,7 @@ def get_irradiance(site_location, date, tilt, surface_azimuth): 'POA': POA_irradiance['poa_global']}) -# Get irradiance data for summer and winter solstice, assuming 25 degree tilt +# Get irradiance data for summer and winter solstice, assuming 25 degrees tilt # and a south facing array summer_irradiance = get_irradiance(site, '06-20-2020', 25, 180) winter_irradiance = get_irradiance(site, '12-21-2020', 25, 180) @@ -67,8 +66,8 @@ def get_irradiance(site_location, date, tilt, surface_azimuth): summer_irradiance['POA'].plot(ax=ax1, label='POA') winter_irradiance['GHI'].plot(ax=ax2, label='GHI') winter_irradiance['POA'].plot(ax=ax2, label='POA') -ax1.set_xlabel('Time of day (Summer)') -ax2.set_xlabel('Time of day (Winter)') +ax1.set_xlabel('Time of day (in Summer)') +ax2.set_xlabel('Time of day (in Winter)') ax1.set_ylabel('Irradiance ($W/m^2$)') ax1.legend() ax2.legend() From 5099aa2f97a580d7a5c06391172a6d5673781223 Mon Sep 17 00:00:00 2001 From: RoyCoding8 Date: Tue, 26 Apr 2022 12:24:03 +0530 Subject: [PATCH 6/6] Update v0.9.1.rst --- docs/sphinx/source/whatsnew/v0.9.1.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/sphinx/source/whatsnew/v0.9.1.rst b/docs/sphinx/source/whatsnew/v0.9.1.rst index 8cdd5b4642..c7e9fdad27 100644 --- a/docs/sphinx/source/whatsnew/v0.9.1.rst +++ b/docs/sphinx/source/whatsnew/v0.9.1.rst @@ -65,6 +65,7 @@ Documentation * Clarify the descriptions of ``delta_t`` in several solar position functions (:pull:`1429`) * Changed $C$ to $\\degree C$ in the plot_singlediode.py file (:pull:`1434`) +* Changed axis labels and comments, and also deleted a string variable which wasn't required (:pull: `1450`) Requirements ~~~~~~~~~~~~