Skip to content

Update cams links #1529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 18, 2022
Merged

Conversation

AdamRJensen
Copy link
Member

  • Closes Update reference in pvlib.iotools.read_cams #1515
  • I am familiar with the contributing guidelines
    - [ ] Tests added
    - [ ] Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

This PR updates the links to the documentation for CAMS radiation (see #1515)

CAMS has requested that the following link be used: https://atmosphere.copernicus.eu/solar-radiation. The two previous links to SoDa's sites for CAMS Radiation and McClear have been removed, although one link to the SoDa remains as it describes the API used by the get_cams function.

Here's an explanation from Marion Schroedter Homscheidt:

ECMWF now made a link to the confluence page (which is the new master documentation source) from the overview page https://atmosphere.copernicus.eu/solar-radiation . . . from there users will find the master documentation and if they need more details the full user guide document (which is linked there as pdf). Please note that there is no separate documentation anymore for CAMS Radiation and CAMS McClear services. The clear-sky model is part of the CAMS Radiation service. So, both links should direct to https://atmosphere.copernicus.eu/solar-radiation. The SoDa pages won’t be deleted as SoDa users may be used to them. But they will be phased out gradually and will in future link also to the CAMS confluence pages.

@AdamRJensen AdamRJensen added io remote-data triggers --remote-data pytests labels Aug 16, 2022
@AdamRJensen AdamRJensen added this to the 0.9.2 milestone Aug 16, 2022
@AdamRJensen AdamRJensen mentioned this pull request Aug 16, 2022
9 tasks
Copy link
Member

@wholmgren wholmgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AdamRJensen. I hope the SodaPro API remains available so that I don't have to bother with cdsapi. Feel free to merge tomorrow unless someone objects.

@AdamRJensen AdamRJensen added remote-data triggers --remote-data pytests and removed remote-data triggers --remote-data pytests labels Aug 17, 2022
@AdamRJensen
Copy link
Member Author

@kanderso-nrel I don't understand why the coverage is failing.. do you have a hint?

@kandersolar
Copy link
Member

Not entirely sure, but it's spurious here of course. Maybe updating w/ the latest master would fix it. In any case fine to ignore it.

@AdamRJensen AdamRJensen merged commit 2fcd6ba into pvlib:master Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
io remote-data triggers --remote-data pytests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update reference in pvlib.iotools.read_cams
3 participants