From 5484c69b1eb8807060296dccccd3992392a14f87 Mon Sep 17 00:00:00 2001 From: RDaxini <143435106+RDaxini@users.noreply.github.com> Date: Wed, 11 Sep 2024 11:39:17 +0100 Subject: [PATCH 1/5] correct doi role --- docs/examples/spectrum/plot_spectrl2_fig51A.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/examples/spectrum/plot_spectrl2_fig51A.py b/docs/examples/spectrum/plot_spectrl2_fig51A.py index 6f3470a246..62ea084ce1 100644 --- a/docs/examples/spectrum/plot_spectrl2_fig51A.py +++ b/docs/examples/spectrum/plot_spectrl2_fig51A.py @@ -19,7 +19,7 @@ # .. [1] Bird, R, and Riordan, C., 1984, "Simple solar spectral model for # direct and diffuse irradiance on horizontal and tilted planes at the # earth's surface for cloudless atmospheres", NREL Technical Report -# TR-215-2436 doi:10.2172/5986936. +# TR-215-2436 :doi:`10.2172/5986936` # %% # The SPECTRL2 model has several inputs; some can be calculated with pvlib, From 4ec13d4a30f127b2330773eae1a44713ef30b9b5 Mon Sep 17 00:00:00 2001 From: RDaxini <143435106+RDaxini@users.noreply.github.com> Date: Wed, 11 Sep 2024 11:42:52 +0100 Subject: [PATCH 2/5] (possible?) clarification to wording --- docs/examples/spectrum/plot_spectrl2_fig51A.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/examples/spectrum/plot_spectrl2_fig51A.py b/docs/examples/spectrum/plot_spectrl2_fig51A.py index 62ea084ce1..44f427e512 100644 --- a/docs/examples/spectrum/plot_spectrl2_fig51A.py +++ b/docs/examples/spectrum/plot_spectrl2_fig51A.py @@ -54,8 +54,10 @@ # %% # With all the necessary inputs in hand we can model spectral irradiance using # :py:func:`pvlib.spectrum.spectrl2`. Note that because we are calculating -# the spectra for more than one set of conditions, we will get back 2-D -# arrays (one dimension for wavelength, one for time). +# the spectra for more than one set of conditions, +# :py:func:`pvlib.spectrum.spectrl2`` will return a dictionary of 2-D arrays +# for the spectral irradiance components (one dimension for wavelength, one for +# time), as well as a separate 1-D array for wavelength. spectra = spectrum.spectrl2( apparent_zenith=solpos.apparent_zenith, From 41e97ea4ee9f785ad8f14d49c5bf9436aa833c2e Mon Sep 17 00:00:00 2001 From: RDaxini <143435106+RDaxini@users.noreply.github.com> Date: Wed, 11 Sep 2024 13:10:24 +0100 Subject: [PATCH 3/5] move references --- docs/examples/spectrum/plot_spectrl2_fig51A.py | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/docs/examples/spectrum/plot_spectrl2_fig51A.py b/docs/examples/spectrum/plot_spectrl2_fig51A.py index 44f427e512..149867048e 100644 --- a/docs/examples/spectrum/plot_spectrl2_fig51A.py +++ b/docs/examples/spectrum/plot_spectrl2_fig51A.py @@ -13,13 +13,6 @@ # This example recreates an example figure from the SPECTRL2 NREL Technical # Report [1]_. The figure shows modeled spectra at hourly intervals across # a single morning. -# -# References -# ---------- -# .. [1] Bird, R, and Riordan, C., 1984, "Simple solar spectral model for -# direct and diffuse irradiance on horizontal and tilted planes at the -# earth's surface for cloudless atmospheres", NREL Technical Report -# TR-215-2436 :doi:`10.2172/5986936` # %% # The SPECTRL2 model has several inputs; some can be calculated with pvlib, @@ -97,3 +90,11 @@ # position and the solar position calculation in the technical report does not # exactly match the one used here. However, the differences are minor enough # to not materially change the spectra. + +# %% +# References +# ---------- +# .. [1] Bird, R, and Riordan, C., 1984, "Simple solar spectral model for +# direct and diffuse irradiance on horizontal and tilted planes at the +# earth's surface for cloudless atmospheres", NREL Technical Report +# TR-215-2436 :doi:`10.2172/5986936` \ No newline at end of file From 0112f389233426c9efd3cce9d1a7cc7114a71468 Mon Sep 17 00:00:00 2001 From: RDaxini <143435106+RDaxini@users.noreply.github.com> Date: Wed, 11 Sep 2024 13:31:58 +0100 Subject: [PATCH 4/5] Update plot_spectrl2_fig51A.py --- docs/examples/spectrum/plot_spectrl2_fig51A.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/docs/examples/spectrum/plot_spectrl2_fig51A.py b/docs/examples/spectrum/plot_spectrl2_fig51A.py index 149867048e..54285348ab 100644 --- a/docs/examples/spectrum/plot_spectrl2_fig51A.py +++ b/docs/examples/spectrum/plot_spectrl2_fig51A.py @@ -46,11 +46,10 @@ # %% # With all the necessary inputs in hand we can model spectral irradiance using -# :py:func:`pvlib.spectrum.spectrl2`. Note that because we are calculating -# the spectra for more than one set of conditions, -# :py:func:`pvlib.spectrum.spectrl2`` will return a dictionary of 2-D arrays -# for the spectral irradiance components (one dimension for wavelength, one for -# time), as well as a separate 1-D array for wavelength. +# :py:func:`pvlib.spectrum.spectrl2`. Note that because we are calculating +# the spectra for more than one set of conditions, the spectral irradiance +# components will be returned in a dictionary as 2-D arrays, with one dimension +# for wavelength and one for time. spectra = spectrum.spectrl2( apparent_zenith=solpos.apparent_zenith, From 36d329297497935898d22028a5f1fee2fe84c327 Mon Sep 17 00:00:00 2001 From: RDaxini <143435106+RDaxini@users.noreply.github.com> Date: Wed, 11 Sep 2024 13:36:53 +0100 Subject: [PATCH 5/5] linter --- docs/examples/spectrum/plot_spectrl2_fig51A.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/examples/spectrum/plot_spectrl2_fig51A.py b/docs/examples/spectrum/plot_spectrl2_fig51A.py index 54285348ab..0a921aaf79 100644 --- a/docs/examples/spectrum/plot_spectrl2_fig51A.py +++ b/docs/examples/spectrum/plot_spectrl2_fig51A.py @@ -96,4 +96,4 @@ # .. [1] Bird, R, and Riordan, C., 1984, "Simple solar spectral model for # direct and diffuse irradiance on horizontal and tilted planes at the # earth's surface for cloudless atmospheres", NREL Technical Report -# TR-215-2436 :doi:`10.2172/5986936` \ No newline at end of file +# TR-215-2436 :doi:`10.2172/5986936`