From e35a56598339b7cda9e5354b1d45fc631ce91098 Mon Sep 17 00:00:00 2001 From: RDaxini <143435106+RDaxini@users.noreply.github.com> Date: Tue, 5 Nov 2024 12:31:18 -0700 Subject: [PATCH 1/6] irradiation -> irradiance, add units --- docs/sphinx/source/user_guide/nomenclature.rst | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/docs/sphinx/source/user_guide/nomenclature.rst b/docs/sphinx/source/user_guide/nomenclature.rst index a89da06cbf..8e1fac9e2d 100644 --- a/docs/sphinx/source/user_guide/nomenclature.rst +++ b/docs/sphinx/source/user_guide/nomenclature.rst @@ -102,20 +102,21 @@ There is a convention on consistent variable names throughout the library: Photocurrent poa_diffuse - Total diffuse irradiation in plane. Sum of ground and sky diffuse. + Total diffuse irradiance in plane [Wm⁻²]. Sum of ground and sky diffuse + components of global irradiance. poa_direct - Direct/beam irradiation in plane + Direct/beam irradiance in plane [Wm⁻²]. poa_global - Global irradiation in plane. sum of diffuse and beam projection. + Global irradiance in plane. sum of diffuse and beam projection [Wm⁻²]. poa_ground_diffuse - In plane ground reflected irradiation + In plane ground reflected irradiance [Wm⁻²]. poa_sky_diffuse - Diffuse irradiation in plane from scattered light in the atmosphere - (without ground reflected irradiation) + Diffuse irradiance in plane from scattered light in the atmosphere + (without ground reflected irradiance) [Wm⁻²]. precipitable_water Total precipitable water contained in a column of unit cross section From ba80caa333b4f05b987727a7974a6633885f72ad Mon Sep 17 00:00:00 2001 From: RDaxini Date: Thu, 21 Nov 2024 10:19:06 -0700 Subject: [PATCH 2/6] Update nomenclature.rst --- docs/sphinx/source/user_guide/nomenclature.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/sphinx/source/user_guide/nomenclature.rst b/docs/sphinx/source/user_guide/nomenclature.rst index 8e1fac9e2d..19dcabb304 100644 --- a/docs/sphinx/source/user_guide/nomenclature.rst +++ b/docs/sphinx/source/user_guide/nomenclature.rst @@ -163,8 +163,8 @@ There is a convention on consistent variable names throughout the library: Temperature of the module transposition_factor - The gain ratio of the radiation on inclined plane to global horizontal - irradiation: :math:`\frac{poa\_global}{ghi}` + The ratio of the irradiance incident on an inclined plane compared with + a horizontal plane, :math:`\frac{poa\_global}{ghi}` tz Timezone From 6d27d6136c26f24eed7614564ef66afa0831df82 Mon Sep 17 00:00:00 2001 From: RDaxini Date: Thu, 21 Nov 2024 10:20:18 -0700 Subject: [PATCH 3/6] Update nomenclature.rst --- docs/sphinx/source/user_guide/nomenclature.rst | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/sphinx/source/user_guide/nomenclature.rst b/docs/sphinx/source/user_guide/nomenclature.rst index 19dcabb304..4e62a041fb 100644 --- a/docs/sphinx/source/user_guide/nomenclature.rst +++ b/docs/sphinx/source/user_guide/nomenclature.rst @@ -163,8 +163,9 @@ There is a convention on consistent variable names throughout the library: Temperature of the module transposition_factor - The ratio of the irradiance incident on an inclined plane compared with - a horizontal plane, :math:`\frac{poa\_global}{ghi}` + The ratio of the irradiance incident on an inclined plane to the + the iradiance incident on a horizontal plane, + :math:`\frac{poa\_global}{ghi}` tz Timezone From 28ef5ac9f1c367624b7f8331994acfd782669e21 Mon Sep 17 00:00:00 2001 From: RDaxini Date: Thu, 21 Nov 2024 10:20:49 -0700 Subject: [PATCH 4/6] typo --- docs/sphinx/source/user_guide/nomenclature.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/sphinx/source/user_guide/nomenclature.rst b/docs/sphinx/source/user_guide/nomenclature.rst index 4e62a041fb..2115e7303f 100644 --- a/docs/sphinx/source/user_guide/nomenclature.rst +++ b/docs/sphinx/source/user_guide/nomenclature.rst @@ -164,7 +164,7 @@ There is a convention on consistent variable names throughout the library: transposition_factor The ratio of the irradiance incident on an inclined plane to the - the iradiance incident on a horizontal plane, + the irradiance incident on a horizontal plane, :math:`\frac{poa\_global}{ghi}` tz From edfbf73842690d4829b4bb807c5c1c5d58603189 Mon Sep 17 00:00:00 2001 From: RDaxini <143435106+RDaxini@users.noreply.github.com> Date: Mon, 25 Nov 2024 12:04:30 -0700 Subject: [PATCH 5/6] Update docs/sphinx/source/user_guide/nomenclature.rst Co-authored-by: Kevin Anderson --- docs/sphinx/source/user_guide/nomenclature.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/sphinx/source/user_guide/nomenclature.rst b/docs/sphinx/source/user_guide/nomenclature.rst index 2115e7303f..d8e634fdd0 100644 --- a/docs/sphinx/source/user_guide/nomenclature.rst +++ b/docs/sphinx/source/user_guide/nomenclature.rst @@ -109,7 +109,7 @@ There is a convention on consistent variable names throughout the library: Direct/beam irradiance in plane [Wm⁻²]. poa_global - Global irradiance in plane. sum of diffuse and beam projection [Wm⁻²]. + Global irradiance in plane. Sum of diffuse and beam projection [Wm⁻²]. poa_ground_diffuse In plane ground reflected irradiance [Wm⁻²]. From 7788e645aaf2255ec5a84849cc1bea58819a388a Mon Sep 17 00:00:00 2001 From: RDaxini Date: Mon, 25 Nov 2024 12:07:37 -0700 Subject: [PATCH 6/6] remove transposition factor --- docs/sphinx/source/user_guide/nomenclature.rst | 5 ----- 1 file changed, 5 deletions(-) diff --git a/docs/sphinx/source/user_guide/nomenclature.rst b/docs/sphinx/source/user_guide/nomenclature.rst index 2115e7303f..db89a052af 100644 --- a/docs/sphinx/source/user_guide/nomenclature.rst +++ b/docs/sphinx/source/user_guide/nomenclature.rst @@ -162,11 +162,6 @@ There is a convention on consistent variable names throughout the library: temp_module Temperature of the module - transposition_factor - The ratio of the irradiance incident on an inclined plane to the - the irradiance incident on a horizontal plane, - :math:`\frac{poa\_global}{ghi}` - tz Timezone