Location.get_rise_set_transit

[cwhanse]

pvlib python pull request guidelines

Thank you for your contribution to pvlib python! You may delete all of these instructions except for the list below.

You may submit a pull request with your code at any stage of completion.

The following items must be addressed before the code can be merged. Please don't hesitate to ask for help if you're unsure of how to accomplish any of the items below:

• Closes add sunrise / sunset to Location #114
• I am familiar with the contributing guidelines.
• Fully tested. Added and/or modified tests to ensure correct behavior for all reasonable inputs. Tests (usually) must pass on the TravisCI and Appveyor testing services.
• Updates entries to docs/sphinx/source/api.rst for API changes.
• Adds description and name entries in the appropriate docs/sphinx/source/whatsnew file for all changes.
• Code quality and style is sufficient. Passes LGTM and SticklerCI checks.
• New code is fully documented. Includes sphinx/numpydoc compliant docstrings and comments in the code where necessary.
• Pull request is nearly complete and ready for detailed review.

Brief description of the problem and proposed solution (if not already fully described in the issue linked to above):

Location method wrapping sun_rise_set_transit_xxx functions.

[cwhanse]

Help me understand this test failure: test_location is importing a Location object golden from test_solarposition but does not bring in the new Location method get_sun_rise_set_transit. Do I need to redeclare golden in test_location?

[cwhanse]

Ready for review

[cwhanse]

Test failure is on py2.7-min, because functions being tested require pyephem.

[cwhanse]

pvlib.SPA error when testing in py36

[wholmgren]

pvlib.SPA error when testing in py36

Strange. The base python is 3.6 but tests run in a conda env with 3.7. I suspect it's related to conda packaging issues that will resolve themselves. That configuration passed on master 8 days ago, but failed on master when I reran it a few minutes ago. So that confirms this PR is not doing something unexpected.

[wholmgren]

Looks good to me.

[wholmgren]

@cwhanse the test failure is unrelated. You can merge this if you're ready.