Skip to content

[RFC, META-ISSUE] Complete continuous integration (CI) for unit-testing, documentation, and test coverage #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
8 tasks
adam2392 opened this issue Mar 10, 2023 · 4 comments
Assignees

Comments

@adam2392
Copy link
Collaborator

adam2392 commented Mar 10, 2023

Hi, this is a meta issue to track the items required to bring causal-learn into a more PRable repository:

This list is to track the high-level issues that need to be resolved in a series of PRs. Each may have some description as well associated regarding what needs to be done in detail, what the end result should look like and some motivation. My recommendation is using a combination of GH actions and circleCI as this has worked well in the past for me, but we can change based on discussion.

Some possible issues that may need to be resolved along the way:

  • Ensure unit-tests run in a reasonable amount of time. I'm not sure how long the unit-tests takes to run currently, but if it requires some intensive computations, then it might be beneficial to refactor to make the unit-tests faster
  • Ensure docs are built in a reasonable amount of time. Examples should be self-contained and short to illustrate a point. If large dataset is needed, one can always trim the dataset and then add a note saying why we did it.

Some implementation details related to CI:

Still a WIP to get this list fully flushed out, but here's a first go at it.

@kunwuz
Copy link
Collaborator

kunwuz commented Mar 11, 2023

Thanks so much for listing these To-Dos and instructions! Let's make the pipeline more robust together :)

@jaron-lee
Copy link

This all looks good. I might add a few points:

  • Pre-commit hooks would help with getting used to CI pipelines
  • Consider adding a changelog functionality?

@MarkDana
Copy link
Collaborator

Thanks Yujia, Adam and Jaron! Very much looking forward to working together on professionalizing causal-learn :)

@tofuwen
Copy link
Contributor

tofuwen commented Mar 22, 2023

Great, thanks all! :)

@tofuwen tofuwen mentioned this issue Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants