Skip to content

BUG: conda forge tutorial has pypi learning objectives #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lwasser opened this issue Mar 8, 2024 · 5 comments
Closed

BUG: conda forge tutorial has pypi learning objectives #201

lwasser opened this issue Mar 8, 2024 · 5 comments
Labels
good first issue Good for newcomers help wanted We welcome a contributor to work on this issue! thank you in advance!

Comments

@lwasser
Copy link
Member

lwasser commented Mar 8, 2024

This is a small fix but currently - the conda forge lesson actually has learning objectives for the pypi lessons. somehow that got missed in review! this is a small but needed fix to update the learning objectives to represent the content on the page properly

LINK: https://www.pyopensci.org/python-package-guide/tutorials/publish-conda-forge.html

What it looks like now:
Screenshot 2024-03-08 at 3 13 11 PM
The learning objectives likely should be something like:

- "Create a conda-forge recipe using grayskull"
- "Submit that package for review and publication on conda-forge."
@lwasser lwasser added the help wanted We welcome a contributor to work on this issue! thank you in advance! label Mar 8, 2024
@lwasser lwasser added the good first issue Good for newcomers label Mar 8, 2024
@miguelalizo
Copy link
Contributor

Pull request submitted for review.

@lwasser
Copy link
Member Author

lwasser commented Apr 9, 2024

this was merged!! closing the issue. many thanks @miguelalizo !!

@lwasser lwasser closed this as completed Apr 9, 2024
@github-project-automation github-project-automation bot moved this to Dev Ops / GitHub actions or GitHub related in pyOpenSci Help Wanted Project Board Apr 9, 2024
@miguelalizo
Copy link
Contributor

First open source PR ✅

Thanks @lwasser !

@lwasser
Copy link
Member Author

lwasser commented Apr 9, 2024

no way @miguelalizo WOW that is awesome!! congratulations on your first OS PR!! yahoo!!

@lwasser
Copy link
Member Author

lwasser commented Apr 9, 2024

and also let's thank @ucodery for leading this at pycascades!! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted We welcome a contributor to work on this issue! thank you in advance!
Projects
Development

No branches or pull requests

2 participants