Skip to content

Add: type hints to docstring examples and a paragraph on what type hints are #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lwasser opened this issue Jan 10, 2023 · 9 comments
Closed
Assignees

Comments

@lwasser
Copy link
Member

lwasser commented Jan 10, 2023

following this comment - this would be good to add to our docs in a future edit once the current pr is merged

see #19 (comment)

@lwasser lwasser added the help wanted We welcome a contributor to work on this issue! thank you in advance! label Jan 10, 2023
@lwasser
Copy link
Member Author

lwasser commented Jan 30, 2023

This pr relates to this page on docstrings and API documentation.

it would be nice to add a section on typing / type hints to this part of the guide.

@SimonMolinsky
Copy link
Contributor

@lwasser is this issue still open for help? :)

@lwasser
Copy link
Member Author

lwasser commented Mar 6, 2023

yes please @SimonMolinsky !! it would be awesome if you could work on it! anything tagged with help wanted is open !! i hope you are well - it's nice to see you online here again!!

@SimonMolinsky
Copy link
Contributor

@lwasser Thanks! Could you assign me to this task? :) I'll fork the project and start working on it :)

It's nice to be here too 💟

@SimonMolinsky
Copy link
Contributor

I need clarifications to be perfectly aligned with the requirements :) Should I modify a specific file or write a short document about type hinting? If the latter, do we have the core example that we present to the readers?

@lwasser
Copy link
Member Author

lwasser commented Mar 7, 2023

absolutely!

this is the page that suggested adding tpe hints:

here you can see the comment

So i think maybe in the "best" example there - (good, better, best for docstrings?) or maybe in the better example we want to add types...

then maybe you can add some text to that page about what type hinting is and how to use it.
we could also then mention mypy as a tool to check types are implemented accurately.

Does that make sense? We could use another example for the docstrings too. i only used earthpy as i knew it had built docs but it's no longer maintained so i'm open to any example for the docstrings there as long as it's very simple!

let me know if you have any other questions! And thank you!

@SimonMolinsky
Copy link
Contributor

Thanks, everything is clear now. I will start with the content that we have - and if I need more, I will find a function from EarthPy with more datatypes (parameters) to explain typing in detail.

@lwasser
Copy link
Member Author

lwasser commented Mar 9, 2023

that would be awesome. And feel free to use a different package in our ecosystem for the examples too since earthpy is no longer being maintained! thank you so much for doing this!

@lwasser lwasser removed the help wanted We welcome a contributor to work on this issue! thank you in advance! label Apr 19, 2023
@lwasser
Copy link
Member Author

lwasser commented Jul 5, 2023

i think we can close this issue as complete. Please feel free reopen if needed !! ✨

@lwasser lwasser closed this as completed Jul 5, 2023
@github-project-automation github-project-automation bot moved this from Beginner Friendly / Non Technical to Dev Ops / GitHub actions related in pyOpenSci Help Wanted Project Board Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants