From 27baac5e13494d5ddfe6caf09dfc6160bcc2a9db Mon Sep 17 00:00:00 2001 From: Leah Wasser Date: Tue, 25 Oct 2022 14:36:00 -0400 Subject: [PATCH 01/10] Why don't u ignore? --- .github/workflows/build-book.yml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.github/workflows/build-book.yml b/.github/workflows/build-book.yml index 03aa3481..d9d1eaf9 100644 --- a/.github/workflows/build-book.yml +++ b/.github/workflows/build-book.yml @@ -53,3 +53,13 @@ jobs: with: github_token: ${{ secrets.GITHUB_TOKEN }} publish_dir: ./_build/html + + # Test for bad links and ensure alt tags for usability + - name: Check HTML using htmlproofer + uses: chabad360/htmlproofer@master + with: + directory: "./_build/html" + arguments: | + --ignore-files ".+\/_static\/.+" + + From 0efa03d03faf37a607f57e66673c3b17b0d50bc1 Mon Sep 17 00:00:00 2001 From: Leah Wasser Date: Tue, 25 Oct 2022 14:47:22 -0400 Subject: [PATCH 02/10] just for giggles --- .github/workflows/build-book.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-book.yml b/.github/workflows/build-book.yml index d9d1eaf9..a3a2ce4b 100644 --- a/.github/workflows/build-book.yml +++ b/.github/workflows/build-book.yml @@ -60,6 +60,6 @@ jobs: with: directory: "./_build/html" arguments: | - --ignore-files ".+\/_static\/.+" + --ignore-files "/_static/" From c65dc1a4edf7bcb759e02c00a1a55478ccacb9d3 Mon Sep 17 00:00:00 2001 From: Leah Wasser Date: Mon, 31 Oct 2022 11:19:56 -0400 Subject: [PATCH 03/10] remove quotes --- .github/workflows/build-book.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-book.yml b/.github/workflows/build-book.yml index a3a2ce4b..08bae0d2 100644 --- a/.github/workflows/build-book.yml +++ b/.github/workflows/build-book.yml @@ -58,7 +58,7 @@ jobs: - name: Check HTML using htmlproofer uses: chabad360/htmlproofer@master with: - directory: "./_build/html" + directory: /_build/html arguments: | --ignore-files "/_static/" From 5b824d0685ecbba33a54a5f21106a45976f2c3d4 Mon Sep 17 00:00:00 2001 From: Leah Wasser Date: Mon, 31 Oct 2022 12:45:11 -0400 Subject: [PATCH 04/10] Redo path --- .github/workflows/build-book.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-book.yml b/.github/workflows/build-book.yml index 08bae0d2..0eaf3223 100644 --- a/.github/workflows/build-book.yml +++ b/.github/workflows/build-book.yml @@ -58,8 +58,8 @@ jobs: - name: Check HTML using htmlproofer uses: chabad360/htmlproofer@master with: - directory: /_build/html + directory: ./_build/html arguments: | - --ignore-files "/_static/" + --ignore-files "/\/_static/" From f018aca6d1830848f4e7e1901582b6e705623a28 Mon Sep 17 00:00:00 2001 From: Leah Wasser Date: Mon, 31 Oct 2022 12:54:02 -0400 Subject: [PATCH 05/10] Only build on PR --- .github/workflows/build-book.yml | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-book.yml b/.github/workflows/build-book.yml index 0eaf3223..b417639c 100644 --- a/.github/workflows/build-book.yml +++ b/.github/workflows/build-book.yml @@ -1,7 +1,14 @@ name: build-test-deploy-book -# Run on pushes and pull requests -on: [push, pull_request] +# Only build PRs, the main branch, and releases. Pushes to branches will only +# be built when a PR is opened. This avoids duplicated buids in PRs comming +# from branches in the origin repository (1 for PR and 1 for push). +# This came from Leo's work with fatiando +on: + pull_request: + push: + branches: + - main # This job installs dependencies, build the book, and pushes it to `gh-pages` jobs: From b84f45fd7a9ec14f0febe9163eeb966a5b877293 Mon Sep 17 00:00:00 2001 From: Leah Wasser Date: Mon, 31 Oct 2022 12:58:01 -0400 Subject: [PATCH 06/10] fix regex --- .github/workflows/build-book.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-book.yml b/.github/workflows/build-book.yml index b417639c..fd17c902 100644 --- a/.github/workflows/build-book.yml +++ b/.github/workflows/build-book.yml @@ -67,6 +67,6 @@ jobs: with: directory: ./_build/html arguments: | - --ignore-files "/\/_static/" + --ignore-files "/.+\/_static\/.+/, /\/_build/html\/_static/" From 20dd14e477e5a5102801684072b4a8cdfc1ff54e Mon Sep 17 00:00:00 2001 From: Leah Wasser Date: Mon, 31 Oct 2022 13:01:49 -0400 Subject: [PATCH 07/10] ignore file --- .github/workflows/build-book.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-book.yml b/.github/workflows/build-book.yml index fd17c902..144f40f6 100644 --- a/.github/workflows/build-book.yml +++ b/.github/workflows/build-book.yml @@ -67,6 +67,6 @@ jobs: with: directory: ./_build/html arguments: | - --ignore-files "/.+\/_static\/.+/, /\/_build/html\/_static/" + --ignore-files "/.+\/_static\/.+/, /_build\/html\/_static\/sbt-webpack-macros.html/" From 7ce1d4b4491fb3c7095070656fcd90b02abe31de Mon Sep 17 00:00:00 2001 From: Leah Wasser Date: Mon, 31 Oct 2022 13:08:00 -0400 Subject: [PATCH 08/10] remove space --- .github/workflows/build-book.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-book.yml b/.github/workflows/build-book.yml index 144f40f6..6c74a420 100644 --- a/.github/workflows/build-book.yml +++ b/.github/workflows/build-book.yml @@ -67,6 +67,6 @@ jobs: with: directory: ./_build/html arguments: | - --ignore-files "/.+\/_static\/.+/, /_build\/html\/_static\/sbt-webpack-macros.html/" + --ignore-files "/.+\/_static\/.+/,/_build\/html\/_static\/sbt-webpack-macros.html/" From 8835bdbe754a6f8a3e1ad2b29e24fa3f4f5c9f3f Mon Sep 17 00:00:00 2001 From: Leah Wasser Date: Mon, 31 Oct 2022 13:09:05 -0400 Subject: [PATCH 09/10] spacing? --- .github/workflows/build-book.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-book.yml b/.github/workflows/build-book.yml index 6c74a420..0e4b3009 100644 --- a/.github/workflows/build-book.yml +++ b/.github/workflows/build-book.yml @@ -67,6 +67,6 @@ jobs: with: directory: ./_build/html arguments: | - --ignore-files "/.+\/_static\/.+/,/_build\/html\/_static\/sbt-webpack-macros.html/" + --ignore-files "/.+\/_static\/.+/" From 26ab344e1d0452575f90b3bb4f05ffc623a572a2 Mon Sep 17 00:00:00 2001 From: Leah Wasser Date: Wed, 2 Nov 2022 15:13:33 -0400 Subject: [PATCH 10/10] Should fix html proofer --- .github/workflows/build-book.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-book.yml b/.github/workflows/build-book.yml index 0e4b3009..e36243e7 100644 --- a/.github/workflows/build-book.yml +++ b/.github/workflows/build-book.yml @@ -65,7 +65,7 @@ jobs: - name: Check HTML using htmlproofer uses: chabad360/htmlproofer@master with: - directory: ./_build/html + directory: '_build/html' arguments: | --ignore-files "/.+\/_static\/.+/"