Skip to content

Commit 1b55758

Browse files
committed
Extend test_base_and_derived_nested_scope test
1 parent 7421420 commit 1b55758

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

tests/test_class.cpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -444,8 +444,10 @@ TEST_SUBMODULE(class_, m) {
444444

445445
py::class_<BaseWithNested> baseWithNested_class(m, "BaseWithNested");
446446
py::class_<DerivedWithNested, BaseWithNested> derivedWithNested_class(m, "DerivedWithNested");
447-
py::class_<BaseWithNested::Nested>(baseWithNested_class, "Nested");
448-
py::class_<DerivedWithNested::Nested>(derivedWithNested_class, "Nested");
447+
py::class_<BaseWithNested::Nested>(baseWithNested_class, "Nested")
448+
.def_static("get_name", []() { return "BaseWithNested::Nested"; });
449+
py::class_<DerivedWithNested::Nested>(derivedWithNested_class, "Nested")
450+
.def_static("get_name", []() { return "DerivedWithNested::Nested"; });
449451
}
450452

451453
template <int N> class BreaksBase { public:

tests/test_class.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -388,4 +388,6 @@ def test_multiple_instances_with_same_pointer(capture):
388388
# https://github.com/pybind/pybind11/issues/1624
389389
def test_base_and_derived_nested_scope():
390390
assert issubclass(m.DerivedWithNested, m.BaseWithNested)
391-
assert m.DerivedWithNested.Nested != m.BaseWithNested.Nested
391+
assert m.BaseWithNested.Nested != m.DerivedWithNested.Nested
392+
assert m.BaseWithNested.Nested.get_name() == "BaseWithNested::Nested"
393+
assert m.DerivedWithNested.Nested.get_name() == "DerivedWithNested::Nested"

0 commit comments

Comments
 (0)